Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2199)

Issue 104104: Add ImageChangeInformation filter to ArraySource to reliably set spacing and origin.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by SJSwarts
Modified:
9 years, 4 months ago
Reviewers:
gael.varoquaux, Gael.Varoquaux, prabhu
Base URL:
https://svn.enthought.com/svn/enthought/Mayavi/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -28 lines) Patch
M enthought/mayavi/sources/array_source.py View 8 chunks +33 lines, -26 lines 0 comments Download
M enthought/mayavi/tools/sources.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
SJSwarts
Please review this patch as discussed on enthought-dev. Thanks, Scott
14 years, 8 months ago (2009-08-13 19:16:15 UTC) #1
SJSwarts
Please review this patch as discussed on enthought-dev. Thanks, Scott
14 years, 8 months ago (2009-08-13 19:22:20 UTC) #2
Gael.Varoquaux
Looks all good to me. Can you confirm it does what you want, in other ...
14 years, 8 months ago (2009-08-13 19:34:18 UTC) #3
Gael.Varoquaux
Actually, I have just realized that this code can be tested. It would be great ...
14 years, 8 months ago (2009-08-13 19:59:41 UTC) #4
Gael.Varoquaux
14 years, 4 months ago (2009-12-20 15:48:14 UTC) #5
On 2009/08/13 19:59:41, Gael.Varoquaux wrote:
> Also, the existing tests are broken by your patch. I haven't had time to check
> if it is just noise, or actual problems. You can run the test suite using
> 'mayavi2 -t'.

OK, I have fixed these failures and checked the patch in.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b