code review 10410045: cmd/go: document that files beginning with . or _ are i...

cmd/go: document that files beginning with . or _ are ignored

Fixes issue 5655.

[adg, 2013-06-19 06:30:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2013-06-19 19:29:00]

LGTM.

Clearer than my last change.

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/help.go
File src/cmd/go/help.go (right):

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/help.go#newcode57
src/cmd/go/help.go:57: File names that begin with "." or "_" are ignored by the
go tool.
do we need to document the reason for this?

[r, 2013-06-19 20:36:14]

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/test.go
File src/cmd/go/test.go (right):

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/test.go#newcode50
src/cmd/go/test.go:50: file names that begin with "." or "_".)
repetitive, and it's not the names that are ignored but the files.

Files whose names begin with "_" (including "_test.go") or "." are ignored.

not sure it's necessary to say why

[adg, 2013-06-19 23:40:09]

PTAL

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/help.go
File src/cmd/go/help.go (right):

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/help.go#newcode57
src/cmd/go/help.go:57: File names that begin with "." or "_" are ignored by the
go tool.
On 2013/06/19 19:29:00, minux wrote:
> do we need to document the reason for this?

The reason is largely historical at this point, and can't be changed. It's
clearer to just stick with the facts.

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/test.go
File src/cmd/go/test.go (right):

https://codereview.appspot.com/10410045/diff/1/src/cmd/go/test.go#newcode50
src/cmd/go/test.go:50: file names that begin with "." or "_".)
On 2013/06/19 20:36:14, r wrote:
> repetitive, and it's not the names that are ignored but the files.
> 
> Files whose names begin with "_" (including "_test.go") or "." are ignored.
> 
> not sure it's necessary to say why

Done.

[r, 2013-06-20 00:04:16]

LGTM

[adg, 2013-06-20 00:29:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=363b75191352 ***

cmd/go: document that files beginning with . or _ are ignored

Fixes issue 5655.

R=golang-dev, minux.ma, r
CC=golang-dev
https://codereview.appspot.com/10410045