Issue 10409046: code review 10409046: goprotobuf: Use already-allocated nested messages if th...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10409046: code review 10409046: goprotobuf: Use already-allocated nested messages if th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by dsymonds

Modified:
12 years, 5 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Use already-allocated nested messages if they exist. This maintains the semantics that unmarshaling the concatenation of two encoded messages is equivalent to merging those messages.

Patch Set 1 #

Patch Set 2 : diff -r c80422e14e2a https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r c80422e14e2a https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r c80422e14e2a https://code.google.com/p/goprotobuf #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -6 lines)			Patch
M	proto/all_test.go	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	proto/decode.go	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 5 months ago (2013-06-20 02:53:24 UTC) #1

dsymonds

12 years, 5 months ago (2013-06-20 03:22:23 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=73e7588f6d4f ***

goprotobuf: Use already-allocated nested messages if they exist.

This maintains the semantics that unmarshaling the concatenation of two
encoded messages is equivalent to merging those messages.

R=r
CC=golang-dev
https://codereview.appspot.com/10409046

Expand All Messages | Collapse All Messages