Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1434)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10405044: code review 10405044: google-api-go-client: update generated code with CL htt... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by francesc
Modified:
12 years, 4 months ago
Reviewers:
adg
CC:
adg, bradfitz, golang-dev
Visibility:
Public.

Description

google-api-go-client: update generated code with CL https://codereview.appspot.com/10234052/

Patch Set 1 #

Patch Set 2 : diff -r 1daa95ee8e04 https://code.google.com/p/google-api-go-client #

Patch Set 3 : diff -r 1daa95ee8e04 https://code.google.com/p/google-api-go-client #

Patch Set 4 : diff -r 1daa95ee8e04 https://code.google.com/p/google-api-go-client #

Patch Set 5 : diff -r 1daa95ee8e04 https://code.google.com/p/google-api-go-client #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42776 lines, -2621 lines) Patch
M adexchangebuyer/v1.1/adexchangebuyer-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adexchangebuyer/v1.1/adexchangebuyer-gen.go View 1 2 3 4 12 chunks +27 lines, -15 lines 0 comments Download
M adexchangebuyer/v1.2/adexchangebuyer-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adexchangebuyer/v1.2/adexchangebuyer-gen.go View 1 2 3 4 12 chunks +27 lines, -15 lines 0 comments Download
M adexchangebuyer/v1/adexchangebuyer-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adexchangebuyer/v1/adexchangebuyer-gen.go View 1 2 3 4 12 chunks +27 lines, -15 lines 0 comments Download
M adexchangeseller/v1/adexchangeseller-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adexchangeseller/v1/adexchangeseller-gen.go View 1 2 3 4 14 chunks +37 lines, -21 lines 0 comments Download
A admin/directory_v1/admin-api.json View 1 2 3 4 1 chunk +2635 lines, -0 lines 0 comments Download
A admin/directory_v1/admin-gen.go View 1 2 3 4 1 chunk +4599 lines, -0 lines 0 comments Download
A admin/reports_v1/admin-api.json View 1 2 3 4 1 chunk +519 lines, -0 lines 0 comments Download
A admin/reports_v1/admin-gen.go View 1 2 3 4 1 chunk +690 lines, -0 lines 0 comments Download
M adsense/v1.1/adsense-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adsense/v1.1/adsense-gen.go View 1 2 3 4 23 chunks +75 lines, -41 lines 0 comments Download
M adsense/v1.2/adsense-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adsense/v1.2/adsense-gen.go View 1 2 3 4 31 chunks +99 lines, -49 lines 0 comments Download
A adsense/v1.3/adsense-api.json View 1 2 3 4 1 chunk +2250 lines, -0 lines 0 comments Download
A adsense/v1.3/adsense-gen.go View 1 2 3 4 1 chunk +4372 lines, -0 lines 0 comments Download
M adsense/v1/adsense-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adsense/v1/adsense-gen.go View 1 2 3 4 8 chunks +16 lines, -12 lines 0 comments Download
M adsensehost/v4.1/adsensehost-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M adsensehost/v4.1/adsensehost-gen.go View 1 2 3 4 29 chunks +90 lines, -44 lines 0 comments Download
M analytics/v2.4/analytics-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M analytics/v2.4/analytics-gen.go View 1 2 3 4 9 chunks +21 lines, -15 lines 0 comments Download
M analytics/v3/analytics-api.json View 1 2 3 4 7 chunks +24 lines, -4 lines 0 comments Download
M analytics/v3/analytics-gen.go View 1 2 3 4 26 chunks +94 lines, -51 lines 0 comments Download
A androidpublisher/v1.1/androidpublisher-api.json View 1 2 3 4 1 chunk +238 lines, -0 lines 0 comments Download
A androidpublisher/v1.1/androidpublisher-gen.go View 1 2 3 4 1 chunk +358 lines, -0 lines 0 comments Download
M androidpublisher/v1/androidpublisher-api.json View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M androidpublisher/v1/androidpublisher-gen.go View 1 2 3 4 5 chunks +13 lines, -15 lines 0 comments Download
M audit/v1/audit-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M audit/v1/audit-gen.go View 1 2 3 4 4 chunks +7 lines, -11 lines 0 comments Download
M bigquery/v2/bigquery-api.json View 1 2 3 4 9 chunks +32 lines, -2 lines 0 comments Download
M bigquery/v2/bigquery-gen.go View 1 2 3 4 30 chunks +110 lines, -45 lines 0 comments Download
M blogger/v2/blogger-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M blogger/v2/blogger-gen.go View 1 2 3 4 12 chunks +35 lines, -23 lines 0 comments Download
M blogger/v3/blogger-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M blogger/v3/blogger-gen.go View 1 2 3 4 19 chunks +58 lines, -32 lines 0 comments Download
M books/v1/books-api.json View 1 2 3 4 4 chunks +41 lines, -2 lines 0 comments Download
M books/v1/books-gen.go View 1 2 3 4 43 chunks +207 lines, -40 lines 0 comments Download
M calendar/v3/calendar-api.json View 1 2 3 4 3 chunks +4 lines, -66 lines 0 comments Download
M calendar/v3/calendar-gen.go View 1 2 3 4 39 chunks +103 lines, -147 lines 0 comments Download
M civicinfo/us_v1/civicinfo-api.json View 1 2 3 4 4 chunks +193 lines, -2 lines 0 comments Download
M civicinfo/us_v1/civicinfo-gen.go View 1 2 3 4 10 chunks +186 lines, -8 lines 0 comments Download
M compute/v1beta14/compute-api.json View 1 2 3 4 5 chunks +272 lines, -4 lines 0 comments Download
M compute/v1beta14/compute-gen.go View 1 2 3 4 58 chunks +633 lines, -106 lines 0 comments Download
A compute/v1beta15/compute-api.json View 1 2 3 4 1 chunk +4860 lines, -0 lines 0 comments Download
A compute/v1beta15/compute-gen.go View 1 2 3 4 1 chunk +7999 lines, -0 lines 0 comments Download
M coordinate/v1/coordinate-api.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M coordinate/v1/coordinate-gen.go View 1 2 3 4 14 chunks +43 lines, -27 lines 0 comments Download
M customsearch/v1/customsearch-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M customsearch/v1/customsearch-gen.go View 1 2 3 4 4 chunks +5 lines, -9 lines 0 comments Download
A datastore/v1beta1/datastore-api.json View 1 2 3 4 1 chunk +933 lines, -0 lines 0 comments Download
A datastore/v1beta1/datastore-gen.go View 1 2 3 4 1 chunk +1006 lines, -0 lines 0 comments Download
M dfareporting/v1.1/dfareporting-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M dfareporting/v1.1/dfareporting-gen.go View 1 2 3 4 16 chunks +49 lines, -29 lines 0 comments Download
A dfareporting/v1.2/dfareporting-api.json View 1 2 3 4 1 chunk +1589 lines, -0 lines 0 comments Download
A dfareporting/v1.2/dfareporting-gen.go View 1 2 3 4 1 chunk +2170 lines, -0 lines 0 comments Download
M dfareporting/v1/dfareporting-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M dfareporting/v1/dfareporting-gen.go View 1 2 3 4 16 chunks +49 lines, -29 lines 0 comments Download
M discovery/v1/discovery-api.json View 1 2 3 4 9 chunks +27 lines, -27 lines 0 comments Download
M discovery/v1/discovery-gen.go View 1 2 3 4 16 chunks +30 lines, -46 lines 0 comments Download
M drive/v1/drive-api.json View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M drive/v1/drive-gen.go View 1 2 3 4 9 chunks +14 lines, -12 lines 0 comments Download
M drive/v2/drive-api.json View 1 2 3 4 15 chunks +28 lines, -3 lines 0 comments Download
M drive/v2/drive-gen.go View 1 2 3 4 70 chunks +208 lines, -87 lines 0 comments Download
M freebase/v1/freebase-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M freebase/v1/freebase-gen.go View 1 2 3 4 8 chunks +16 lines, -12 lines 0 comments Download
M freebase/v1sandbox/freebase-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M freebase/v1sandbox/freebase-gen.go View 1 2 3 4 8 chunks +16 lines, -12 lines 0 comments Download
M gan/v1beta1/gan-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M gan/v1beta1/gan-gen.go View 1 2 3 4 13 chunks +44 lines, -30 lines 0 comments Download
M groupsmigration/v1/groupsmigration-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M groupsmigration/v1/groupsmigration-gen.go View 1 2 3 4 5 chunks +6 lines, -10 lines 0 comments Download
M groupssettings/v1/groupssettings-api.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M groupssettings/v1/groupssettings-gen.go View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M latitude/v1/latitude-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M latitude/v1/latitude-gen.go View 1 2 3 4 10 chunks +19 lines, -11 lines 0 comments Download
M licensing/v1/licensing-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M licensing/v1/licensing-gen.go View 1 2 3 4 10 chunks +34 lines, -26 lines 0 comments Download
M mirror/v1/mirror-api.json View 1 2 3 4 5 chunks +8 lines, -6 lines 0 comments Download
M mirror/v1/mirror-gen.go View 1 2 3 4 32 chunks +104 lines, -28 lines 0 comments Download
M oauth2/v1/oauth2-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M oauth2/v1/oauth2-gen.go View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M oauth2/v2/oauth2-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M oauth2/v2/oauth2-gen.go View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M orkut/v2/orkut-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M orkut/v2/orkut-gen.go View 1 2 3 4 38 chunks +125 lines, -61 lines 0 comments Download
M pagespeedonline/v1/pagespeedonline-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M pagespeedonline/v1/pagespeedonline-gen.go View 1 2 3 4 4 chunks +5 lines, -9 lines 0 comments Download
M plus/v1/plus-api.json View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download
M plus/v1/plus-gen.go View 1 2 3 4 18 chunks +47 lines, -27 lines 0 comments Download
M prediction/v1.2/prediction-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M prediction/v1.2/prediction-gen.go View 1 2 3 4 9 chunks +20 lines, -14 lines 0 comments Download
M prediction/v1.3/prediction-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M prediction/v1.3/prediction-gen.go View 1 2 3 4 9 chunks +20 lines, -14 lines 0 comments Download
M prediction/v1.4/prediction-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M prediction/v1.4/prediction-gen.go View 1 2 3 4 9 chunks +20 lines, -14 lines 0 comments Download
M prediction/v1.5/prediction-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M prediction/v1.5/prediction-gen.go View 1 2 3 4 11 chunks +25 lines, -15 lines 0 comments Download
M reseller/v1/reseller-api.json View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
M reseller/v1/reseller-gen.go View 1 2 3 4 16 chunks +46 lines, -25 lines 0 comments Download
M reseller/v1sandbox/reseller-api.json View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M reseller/v1sandbox/reseller-gen.go View 1 2 3 4 16 chunks +46 lines, -25 lines 0 comments Download
M shopping/v1/shopping-api.json View 1 2 3 4 3 chunks +4 lines, -32 lines 0 comments Download
M shopping/v1/shopping-gen.go View 1 2 3 4 11 chunks +12 lines, -106 lines 0 comments Download
M siteverification/v1/siteverification-api.json View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M siteverification/v1/siteverification-gen.go View 1 2 3 4 11 chunks +22 lines, -14 lines 0 comments Download
A sqladmin/v1beta1/sqladmin-api.json View 1 2 3 4 1 chunk +1184 lines, -0 lines 0 comments Download
A sqladmin/v1beta1/sqladmin-gen.go View 1 2 3 4 1 chunk +1776 lines, -0 lines 0 comments Download
M storage/v1beta1/storage-api.json View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M storage/v1beta1/storage-gen.go View 1 2 3 4 28 chunks +91 lines, -49 lines 0 comments Download
M storage/v1beta2/storage-api.json View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M storage/v1beta2/storage-gen.go View 1 2 3 4 38 chunks +128 lines, -66 lines 0 comments Download
M taskqueue/v1beta1/taskqueue-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M taskqueue/v1beta1/taskqueue-gen.go View 1 2 3 4 8 chunks +25 lines, -21 lines 0 comments Download
M taskqueue/v1beta2/taskqueue-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M taskqueue/v1beta2/taskqueue-gen.go View 1 2 3 4 11 chunks +39 lines, -29 lines 0 comments Download
M tasks/v1/tasks-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M tasks/v1/tasks-gen.go View 1 2 3 4 17 chunks +48 lines, -26 lines 0 comments Download
M translate/v2/translate-api.json View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M translate/v2/translate-gen.go View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M urlshortener/v1/urlshortener-api.json View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M urlshortener/v1/urlshortener-gen.go View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M webfonts/v1/webfonts-api.json View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M webfonts/v1/webfonts-gen.go View 1 2 3 4 4 chunks +5 lines, -9 lines 0 comments Download
M youtube/v3/youtube-api.json View 1 2 3 4 65 chunks +557 lines, -355 lines 0 comments Download
M youtube/v3/youtube-gen.go View 1 2 3 4 123 chunks +946 lines, -370 lines 0 comments Download
M youtubeanalytics/v1/youtubeanalytics-api.json View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M youtubeanalytics/v1/youtubeanalytics-gen.go View 1 2 3 4 5 chunks +6 lines, -10 lines 0 comments Download
M youtubeanalytics/v1beta1/youtubeanalytics-api.json View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M youtubeanalytics/v1beta1/youtubeanalytics-gen.go View 1 2 3 4 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 3
francesc
Hello adg@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/google-api-go-client
12 years, 4 months ago (2013-06-18 22:11:19 UTC) #1
adg
LGTM
12 years, 4 months ago (2013-06-18 22:24:48 UTC) #2
francesc
12 years, 4 months ago (2013-06-18 22:27:10 UTC) #3 
*** Submitted as
https://code.google.com/p/google-api-go-client/source/detail?r=3b304bfffd89 ***

google-api-go-client: update generated code with CL
https://codereview.appspot.com/10234052/

R=adg, bradfitz
CC=golang-dev
https://codereview.appspot.com/10405044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b