Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2241)

Issue 10402045: code review 10402045: os/exec: fix leaked http transport in TestExtraFiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dfc
Modified:
10 years, 8 months ago
Reviewers:
minux1, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

os/exec: fix leaked http transport in TestExtraFiles The http.Get call was leaking a file descriptor. This fd would normally be cleaned up by the finaliser on os.File, but occasionally this was not done in time. I originally believed this would address issue 5593, but I think the comment, http://golang.org/src/pkg/os/file_unix.go#L82, explains why this test is unreliable on OS X 10.6

Patch Set 1 #

Patch Set 2 : diff -r 8e10088eb699 https://code.google.com/p/go #

Patch Set 3 : diff -r 8e10088eb699 https://code.google.com/p/go #

Patch Set 4 : diff -r 8e10088eb699 https://code.google.com/p/go #

Patch Set 5 : diff -r 56909cb770fe https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/pkg/os/exec/exec_test.go View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2013-06-19 03:39:10 UTC) #1
minux1
if we just want to force loading the root certificates, we just need this one ...
10 years, 10 months ago (2013-06-19 19:38:01 UTC) #2
dfc
Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 10 months ago (2013-06-22 10:49:25 UTC) #3
dfc
10 years, 10 months ago (2013-06-22 10:49:43 UTC) #4
On 2013/06/19 19:38:01, minux wrote:
> if we just want to force loading the root certificates, we just need this
> one liner:
> (&x509.Certificate{}).Verify(x509.VerifyOptions{})

Thank you for your suggestion. PTAL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b