code review 10402043: go.crypto/ocsp: allow cert-less responses and support m...

go.crypto/ocsp: allow cert-less responses and support making requests.

Some OCSP responses (notably COMODO's) don't use an intermediate
certificate to sign OCSP responses so this change allowed that.

Additionally, a CreateRequest function is added for creating OCSP
requests.

This change makes one API change: SerialNumber becomes a *big.Int to
match crypto/x509. The original code dates to before encoding/asn1
could cope with big.Ints and using a []byte was a workaround for that.

[agl1, 2013-06-18 17:46:55]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[agl1, 2013-06-20 15:11:30]

*** Submitted as
https://code.google.com/p/go/source/detail?r=32525e9c4e9f&repo=crypto ***

go.crypto/ocsp: allow cert-less responses and support making requests.

Some OCSP responses (notably COMODO's) don't use an intermediate
certificate to sign OCSP responses so this change allowed that.

Additionally, a CreateRequest function is added for creating OCSP
requests.

This change makes one API change: SerialNumber becomes a *big.Int to
match crypto/x509. The original code dates to before encoding/asn1
could cope with big.Ints and using a []byte was a workaround for that.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/10402043

[bradfitz, 2013-06-20 17:06:37]

LGTM

https://codereview.appspot.com/10402043/diff/9001/ocsp/ocsp.go
File ocsp/ocsp.go (right):

https://codereview.appspot.com/10402043/diff/9001/ocsp/ocsp.go#newcode263
ocsp/ocsp.go:263: // Hash contains the hash function that should be used when
document the meaning of the zero value.  right now it's not even obvious that
zero is allowed.