Issue 10401044: runner: fix possible shutdown deadlocks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10401044: runner: fix possible shutdown deadlocks

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rog

Modified:
10 years, 10 months ago

Reviewers:
mp+170260, dave

Visibility:
Public.

Description

runner: fix possible shutdown deadlocks When the runner was shutting down, it ignored requests, which could cause deadlocks in some cases. [reproposal of https://codereview.appspot.com/9770043/] https://code.launchpad.net/~rogpeppe/juju-core/314-alt-worker-fix-runner-deadlock/+merge/170260 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : runner: fix possible shutdown deadlocks #

Patch Set 3 : runner: fix possible shutdown deadlocks #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -59 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/runner.go	View	1 2	6 chunks	+75 lines, -50 lines	1 comment	Download
M	worker/runner_test.go	View		5 chunks	+109 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 10 months ago (2013-06-24 07:24:37 UTC) #2

LGTM with minor comment. This is bloody complicated.

https://codereview.appspot.com/10401044/diff/6001/worker/runner.go
File worker/runner.go (right):

https://codereview.appspot.com/10401044/diff/6001/worker/runner.go#newcode117
worker/runner.go:117: log.Debugf("worker: killing runner %p %s", runner)
vet would complain about his line.

Expand All Messages | Collapse All Messages