Add SetCharm to Go sandbox

Add SetCharm to Go sandbox

This adds the new functionality from core of setting a service's charm (primarily for the purpose of upgrading) to the Go environment, sandbox, and fakebackend.  This isn't implemented anywhere in the GUI yet, as there is no UX definition yet.  Additionally, this doesn't address the concern of this functionality missing in the python backend (a card has been created for that).

https://code.launchpad.net/~makyo/juju-gui/set-charm-go-sandbox/+merge/170146

(do not edit description out of merge proposal)

[matthew.scott, 2013-06-18 17:29:44]

Please take a look.

[benji, 2013-06-20 16:33:04]

Thanks for the branch, it looks good.  I had a couple of small things to point
out.

LGTM-ly, y'rs
Benji

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js#n...
app/store/env/fakebackend.js:324: @return {undefined} Get the result from the
callback.
I can't parse this sentence.

https://codereview.appspot.com/10401043/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/go.js#newcode421
app/store/env/go.js:421: for the user callback.
Maybe "into a form which is" instead "into that".

https://codereview.appspot.com/10401043/diff/1/app/store/env/go.js#newcode425
app/store/env/go.js:425: call site.
I think you forgot an indent here.

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js#newco...
app/store/env/sandbox.js:857: @param {Object} state An instance of FakeBackend.
We need an @return here.

https://codereview.appspot.com/10401043/diff/1/test/test_fakebackend.js
File test/test_fakebackend.js (right):

https://codereview.appspot.com/10401043/diff/1/test/test_fakebackend.js#newco...
test/test_fakebackend.js:247: describe('FakeBackend.setCharm', function() {
Nice test suite.

[bac, 2013-06-20 18:24:07]

Thanks Matt - LGTM.

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js#n...
app/store/env/fakebackend.js:324: @return {undefined} Get the result from the
callback.
On 2013/06/20 16:33:04, benji wrote:
> I can't parse this sentence.

How about

"No results are returned from this method call but are instead available via the
callback."

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js#newco...
app/store/env/sandbox.js:695: GoJujuAPI.NAME = 'sandbox-go-juju-api';
Guess this field isn't so important if it has always been wrong.

[benji, 2013-06-20 18:35:38]

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/fakebackend.js#n...
app/store/env/fakebackend.js:324: @return {undefined} Get the result from the
callback.
On 2013/06/20 18:24:07, bac wrote:
> On 2013/06/20 16:33:04, benji wrote:
> > I can't parse this sentence.
> 
> How about
> 
> "No results are returned from this method call but are instead available via
the
> callback."

+1

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/10401043/diff/1/app/store/env/sandbox.js#newco...
app/store/env/sandbox.js:695: GoJujuAPI.NAME = 'sandbox-go-juju-api';
On 2013/06/20 18:24:07, bac wrote:
> Guess this field isn't so important if it has always been wrong.

I thought the same thing.  I wonder what use it is.

[matthew.scott, 2013-06-20 19:21:58]

*** Submitted:

Add SetCharm to Go sandbox

This adds the new functionality from core of setting a service's charm
(primarily for the purpose of upgrading) to the Go environment, sandbox, and
fakebackend.  This isn't implemented anywhere in the GUI yet, as there is no UX
definition yet.  Additionally, this doesn't address the concern of this
functionality missing in the python backend (a card has been created for that).

R=benji, bac
CC=
https://codereview.appspot.com/10401043