code review 10400044: go.tools/cmd/vet: use directory for pkg.path if path is "."

go.tools/cmd/vet: use directory for pkg.path if path is "."
Before:
        math/big/nat_test.go:688: arg r for printf verb %s of wrong type: ..Word
After:
        math/big/nat_test.go:688: arg r for printf verb %s of wrong type: big.Word

[r, 2013-06-18 20:55:12]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[gri, 2013-06-18 20:56:14]

LGTM


On Tue, Jun 18, 2013 at 1:55 PM, <r@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**tools <https://code.google.com/p/go.tools>
>
>
> Description:
> go.tools/cmd/vet: use directory for pkg.path if path is "."
> Before:
>         math/big/nat_test.go:688: arg r for printf verb %s of wrong
> type: ..Word
> After:
>         math/big/nat_test.go:688: arg r for printf verb %s of wrong
> type: big.Word
>
> Please review this at
https://codereview.appspot.**com/10400044/<https://codereview.appspot.com/104...
>
> Affected files:
>   M cmd/vet/main.go
>
>
> Index: cmd/vet/main.go
> ==============================**==============================**=======
> --- a/cmd/vet/main.go
> +++ b/cmd/vet/main.go
> @@ -220,6 +220,10 @@
>                 files = append(files, &File{fset: fs, content: data, name:
> name, file: parsedFile})
>         }
>         pkg := new(Package)
> +       if directory == "." {
> +               // Special case: Use the base name so we don't see "." as
> the package name in messages.
> +               directory = filepath.Base(filepath.Dir(**names[0]))
> +       }
>         pkg.path = directory
>         pkg.files = files
>         // Type check the package.
>
>
>

[r, 2013-06-18 21:02:04]

*** Submitted as
https://code.google.com/p/go/source/detail?r=87ef65cf640a&repo=tools ***

go.tools/cmd/vet: use directory for pkg.path if path is "."
Before:
        math/big/nat_test.go:688: arg r for printf verb %s of wrong type: ..Word
After:
        math/big/nat_test.go:688: arg r for printf verb %s of wrong type:
big.Word

R=gri
CC=golang-dev
https://codereview.appspot.com/10400044