Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4645)

Issue 10395043: Expose 'use-analytics' via the charm.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by bac
Modified:
10 years, 10 months ago
Reviewers:
teknico, matthew.scott, mp+170118
Visibility:
Public.

Description

Expose 'use-analytics' via the charm. https://code.launchpad.net/~bac/charms/precise/juju-gui/expose-cookies/+merge/170118 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Expose 'use-analytics' via the charm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 chunk +10 lines, -0 lines 0 comments Download
M config/config.js.template View 1 chunk +1 line, -0 lines 0 comments Download
M hooks/backend.py View 1 chunk +2 lines, -1 line 0 comments Download
M hooks/utils.py View 2 chunks +2 lines, -1 line 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 10 months ago (2013-06-18 15:51:53 UTC) #1
teknico
LGTM, where "G" means "flawless". :-)
10 years, 10 months ago (2013-06-18 16:18:16 UTC) #2
matthew.scott
LGTM - thanks for getting this plugged in
10 years, 10 months ago (2013-06-18 17:56:16 UTC) #3
bac
10 years, 10 months ago (2013-06-18 18:27:33 UTC) #4
*** Submitted:

Expose 'use-analytics' via the charm.

R=teknico, matthew.scott
CC=
https://codereview.appspot.com/10395043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b