Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1039)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10386044: Handling of subscribers metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by ana.balica
Modified:
10 years, 11 months ago
Reviewers:
ReimarBauer, waldi
Visibility:
Public.

Description

* Add the new keyword to metadata * Store or remove subscribers itemid (profile's userid) on `/+subscribe/` action.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Handling of subscribers metadata #

Total comments: 2

Patch Set 3 : Fix String naming in subscribers meta #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M MoinMoin/storage/middleware/validation.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
waldi
https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py#newcode1001 MoinMoin/apps/frontend/views.py:1001: elif u.is_subscribed_to([item_name]): You may want to remove the old ...
10 years, 11 months ago (2013-06-18 15:06:13 UTC) #1
ana.balica
https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py#newcode1001 MoinMoin/apps/frontend/views.py:1001: elif u.is_subscribed_to([item_name]): Ok. I am making the appropriate changes ...
10 years, 11 months ago (2013-06-18 17:03:15 UTC) #2
ana.balica
https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/10386044/diff/1/MoinMoin/apps/frontend/views.py#newcode1001 MoinMoin/apps/frontend/views.py:1001: elif u.is_subscribed_to([item_name]): The user-object code will be changed at ...
10 years, 11 months ago (2013-06-19 16:45:50 UTC) #3
ReimarBauer
may be check for nonexisting items too https://codereview.appspot.com/10386044/diff/6001/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/10386044/diff/6001/MoinMoin/apps/frontend/views.py#newcode993 MoinMoin/apps/frontend/views.py:993: abort(403) may ...
10 years, 11 months ago (2013-06-20 04:33:27 UTC) #4
ana.balica
10 years, 11 months ago (2013-06-20 08:14:48 UTC) #5 
https://codereview.appspot.com/10386044/diff/6001/MoinMoin/apps/frontend/view...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/10386044/diff/6001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:993: abort(403)
Made the change and failed the test.
Apparently user can subscribe to non-existing items.

def test_subscribe_item(self):
        self._test_view('frontend.subscribe_item', status='302 FOUND',
viewopts=dict(item_name='DoesntExist'), data=['<!DOCTYPE HTML'])

That was possible with the old way of storing the `subscribed_items` - via
interwiki names, all of them being treated as regexps. Should we change the test
(status='404 NOT FOUND') or include the nonexiting item to the regexps meta?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b