Issue 10384046: state/machine: new agent API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10384046: state/machine: new agent API

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rog

Modified:
10 years, 10 months ago

Reviewers:
mp+170306

Visibility:
Public.

Description

state/machine: new agent API As discussed, for testing reasons it makes sense to place APIs for a given agent alongside one another, so this CL puts the machiner API and the machine agent API alongside one another. Client-side machine agent API in a subsequent CL. Re-proposing to avoid the prereq, which I can't submit right now. Original CL here: https://codereview.appspot.com/10398043/ https://code.launchpad.net/~rogpeppe/juju-core/321-apiserver-machineagent-api/+merge/170306 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -106 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	state/api/params/params.go	View		2 chunks	+30 lines, -0 lines	0 comments	Download
M	state/apiserver/common/interfaces.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/login_test.go	View		2 chunks	+4 lines, -3 lines	0 comments	Download
A	state/apiserver/machine/agent.go	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
A	state/apiserver/machine/agent_test.go	View		1 chunk	+91 lines, -0 lines	0 comments	Download
A	state/apiserver/machine/common_test.go	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	state/apiserver/machine/machiner.go	View		7 chunks	+12 lines, -12 lines	0 comments	Download
M	state/apiserver/machine/machiner_test.go	View		3 chunks	+9 lines, -61 lines	0 comments	Download
M	state/apiserver/root.go	View		3 chunks	+22 lines, -13 lines	0 comments	Download
M	state/machine.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	state/state_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages