Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8625)

Issue 10383048: code review 10383048: cmd/gc: fix issue with method wrappers not having escap... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by DMorsing
Modified:
9 years, 5 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: fix issue with method wrappers not having escape analysis run on them. Escape analysis needs the right curfn value on a dclfunc node, otherwise it will not analyze the function. When generating method value wrappers, we forgot to set the curfn correctly. Fixes issue 5753.

Patch Set 1 #

Patch Set 2 : diff -r 56909cb770fe https://code.google.com/p/go/ #

Patch Set 3 : diff -r 56909cb770fe https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3a652b14dccc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/cmd/gc/closure.c View 1 4 chunks +6 lines, -1 line 0 comments Download
A test/fixedbugs/issue5753.go View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5
DMorsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2013-06-22 20:20:27 UTC) #1
DMorsing
ping?
9 years, 5 months ago (2013-06-25 21:08:01 UTC) #2
rsc
sorry, just overwhelmed by all the runtime stuff. will review tomorrow.
9 years, 5 months ago (2013-06-27 03:17:58 UTC) #3
rsc
LGTM Ouch.
9 years, 5 months ago (2013-07-02 00:53:43 UTC) #4
DMorsing
9 years, 5 months ago (2013-07-02 15:12:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=58e15340e78f ***

cmd/gc: fix issue with method wrappers not having escape analysis run on them.

Escape analysis needs the right curfn value on a dclfunc node, otherwise it will
not analyze the function.
When generating method value wrappers, we forgot to set the curfn correctly.

Fixes issue 5753.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10383048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b