Use localhost only if pressent for opening state

Use localhost only if pressent for opening state

Recently a change was made so localhost is added in the list
of addresses to open state if we are servingstatus.
In that change the addresses where sorted to favor localhost
ones, with this new change, if localhost is present, its the
only one used and the other ones are discarded.

https://code.launchpad.net/~hduran-8/juju-core/apiworker_force_local_only/+merge/221788

(do not edit description out of merge proposal)

[hduran, 2014-06-02 20:59:54]

Please take a look.

[thumper, 2014-06-02 21:08:23]

given that localhost should not be in the list more than once, LGTM

bonus points if you fix the test not to use a hard coded port number in a test
you didn't touch :-)

https://codereview.appspot.com/103820044/diff/1/state/api/apiclient_test.go
File state/api/apiclient_test.go (right):

https://codereview.appspot.com/103820044/diff/1/state/api/apiclient_test.go#n...
state/api/apiclient_test.go:30: listener, err := net.Listen("tcp",
"localhost:26104")
hard coded port number in the test? really?

[hduran, 2014-06-03 01:05:00]

Please take a look.

https://codereview.appspot.com/103820044/diff/1/state/api/apiclient_test.go
File state/api/apiclient_test.go (right):

https://codereview.appspot.com/103820044/diff/1/state/api/apiclient_test.go#n...
state/api/apiclient_test.go:30: listener, err := net.Listen("tcp",
"localhost:26104")
On 2014/06/02 21:08:23, thumper wrote:
> hard coded port number in the test? really?

Done.

[thumper, 2014-06-03 01:38:51]

LGTM, just wondering about cleaning up that test.  You are good to land if you
cannot use the result of the listen address.

https://codereview.appspot.com/103820044/diff/20001/state/api/apiclient_test.go
File state/api/apiclient_test.go (right):

https://codereview.appspot.com/103820044/diff/20001/state/api/apiclient_test....
state/api/apiclient_test.go:48: _, port, err :=
net.SplitHostPort(listenerAddress)
Can't you just use this as the expectedHostPort?

[hduran, 2014-06-03 01:44:56]

https://codereview.appspot.com/103820044/diff/20001/state/api/apiclient_test.go
File state/api/apiclient_test.go (right):

https://codereview.appspot.com/103820044/diff/20001/state/api/apiclient_test....
state/api/apiclient_test.go:48: _, port, err :=
net.SplitHostPort(listenerAddress)
On 2014/06/03 01:38:50, thumper wrote:
> Can't you just use this as the expectedHostPort?

No, even though I start the listener using localhost, the Addr method returns
the ip, so I get the port and use it.

[jameinel, 2014-06-03 12:22:55]

LGTM

A comment about "listenAddress contains the actual IP address, but APIHostPorts
is going to report localhost, so just find the port"