Issue 10365052: code review 10365052: test: match gccgo error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10365052: code review 10365052: test: match gccgo error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by remyoudompheng

Modified:
11 years, 10 months ago

Reviewers:
iant

CC:
iant, golang-dev

Visibility:
Public.

Description

test: match gccgo error messages

Patch Set 1 #

Patch Set 2 : diff -r 363b75191352 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 363b75191352 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 363b75191352 https://go.googlecode.com/hg/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	test/fixedbugs/bug205.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/fixedbugs/bug459.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/issue3783.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/issue3925.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/issue4097.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/issue4458.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/issue4545.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello iant@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 10 months ago (2013-06-20 05:57:13 UTC) #1

iant

LGTM Thanks. I assume you've verified that the gc build still works.

11 years, 10 months ago (2013-06-20 05:59:51 UTC) #2

remyoudompheng

11 years, 10 months ago (2013-06-20 06:21:21 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b2560a1d1e52 ***

test: match gccgo error messages

R=iant, golang-dev
CC=golang-dev
https://codereview.appspot.com/10365052

Expand All Messages | Collapse All Messages