Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1427)

Issue 10364050: code review 10364050: go.tools/cmd/cover: skip mode line (first line of profile) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by r
Modified:
11 years, 11 months ago
Reviewers:
rsc
CC:
adg, rsc, golang-dev
Visibility:
Public.

Description

go.tools/cmd/cover: skip mode line (first line of profile) Still to do: use the mode to affect how to present the data.

Patch Set 1 #

Patch Set 2 : diff -r 87fa70483468 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M cmd/cover/html.go View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 11 months ago (2013-06-21 17:46:00 UTC) #1
rsc
LGTM
11 years, 11 months ago (2013-06-21 19:12:56 UTC) #2
r
11 years, 11 months ago (2013-06-21 21:19:59 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=a2603d0ee4a8&repo=tools ***

go.tools/cmd/cover: skip mode line (first line of profile)
Still to do: use the mode to affect how to present the data.

R=adg, rsc
CC=golang-dev
https://codereview.appspot.com/10364050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b