Issue 10364046: state/api/machiner: rename Machiner to State

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10364046: state/api/machiner: rename Machiner to State

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rog

Modified:
10 years, 10 months ago

Reviewers:
mp+170400, thumper, wallyworld

Visibility:
Public.

Description

state/api/machiner: rename Machiner to State As discussed online. Also make the Machiner entry point consistent with Client by not returning an error. https://code.launchpad.net/~rogpeppe/juju-core/323-machineagent-api-client/+merge/170400 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api/machiner: rename Machiner to State #

Patch Set 3 : state/api/machiner: rename Machiner to State #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -49 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	state/api/machiner/machine.go	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	state/api/machiner/machiner.go	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	state/api/machiner/machiner_test.go	View		5 chunks	+9 lines, -10 lines	0 comments	Download
M	state/api/state.go	View		1 chunk	+4 lines, -13 lines	0 comments	Download
M	state/apiserver/login_test.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/server_test.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thumper

On 2013/06/19 16:35:49, rog wrote: > Please take a look. LGTM - I still hate ...

10 years, 10 months ago (2013-06-20 02:33:48 UTC) #2

LGTM

Expand All Messages | Collapse All Messages