Some testing code refactoring.

Some testing code refactoring.

Move state.TestingEnvironConfig into testing/environ.go and
rename to EnvironConfig, so usage looks like testing.EnvironConfig.
Also renamed InvalidStateInfo and InvalidApiInfo to FakeStateInfo
and FakeApiInfo.

https://code.launchpad.net/~thumper/juju-core/invalid-state-rename/+merge/169962

(do not edit description out of merge proposal)

[thumper, 2013-06-17 23:14:48]

Please take a look.

[dave_cheney.net, 2013-06-17 23:42:13]

LGTM. Very nice, thank you.

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go
File environs/ec2/live_test.go (right):

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go#newc...
environs/ec2/live_test.go:133: inst, err := t.Env.StartInstance("31",
"fake_nonce", config.DefaultSeries, cons, testing.FakeStateInfo("31"),
testing.FakeAPIInfo("31"))
s/Fake/Mock, whatever, personal preference.

https://codereview.appspot.com/10344044/diff/1/state/initialize_test.go
File state/initialize_test.go (left):

https://codereview.appspot.com/10344044/diff/1/state/initialize_test.go#oldco...
state/initialize_test.go:55: cfg := state.TestingEnvironConfig(c)
excellent, state should know nothing about the test mocks.

https://codereview.appspot.com/10344044/diff/1/testing/environ.go
File testing/environ.go (right):

https://codereview.appspot.com/10344044/diff/1/testing/environ.go#newcode14
testing/environ.go:14: // EnvironConfig returns a default environment
configuration.
// EnvironConfig returns a default environment configuration suitable for
testing.

[wallyworld, 2013-06-18 01:58:25]

LGTM, niiiice

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go
File environs/ec2/live_test.go (right):

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go#newc...
environs/ec2/live_test.go:133: inst, err := t.Env.StartInstance("31",
"fake_nonce", config.DefaultSeries, cons, testing.FakeStateInfo("31"),
testing.FakeAPIInfo("31"))
On 2013/06/17 23:42:13, dfc wrote:
> s/Fake/Mock, whatever, personal preference.

+1 :-)

https://codereview.appspot.com/10344044/diff/1/state/initialize_test.go
File state/initialize_test.go (left):

https://codereview.appspot.com/10344044/diff/1/state/initialize_test.go#oldco...
state/initialize_test.go:55: cfg := state.TestingEnvironConfig(c)
On 2013/06/17 23:42:13, dfc wrote:
> excellent, state should know nothing about the test mocks.

+100 \o/

[thumper, 2013-06-18 03:16:12]

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go
File environs/ec2/live_test.go (right):

https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go#newc...
environs/ec2/live_test.go:133: inst, err := t.Env.StartInstance("31",
"fake_nonce", config.DefaultSeries, cons, testing.FakeStateInfo("31"),
testing.FakeAPIInfo("31"))
On 2013/06/18 01:58:25, wallyworld wrote:
> On 2013/06/17 23:42:13, dfc wrote:
> > s/Fake/Mock, whatever, personal preference.
> 
> +1 :-)

Going to stick with Fakes here as Mocks are normally different implementations
with internal assertions.

https://codereview.appspot.com/10344044/diff/1/testing/environ.go
File testing/environ.go (right):

https://codereview.appspot.com/10344044/diff/1/testing/environ.go#newcode14
testing/environ.go:14: // EnvironConfig returns a default environment
configuration.
On 2013/06/17 23:42:13, dfc wrote:
> // EnvironConfig returns a default environment configuration suitable for
> testing.

Done.

[dave_cheney.net, 2013-06-18 03:44:14]

Jolly good. LGTM. 

On 18/06/2013, at 13:16, tim.penhey@canonical.com wrote:

> 
> https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go
> File environs/ec2/live_test.go (right):
> 
>
https://codereview.appspot.com/10344044/diff/1/environs/ec2/live_test.go#newc...
> environs/ec2/live_test.go:133: inst, err := t.Env.StartInstance("31",
> "fake_nonce", config.DefaultSeries, cons, testing.FakeStateInfo("31"),
> testing.FakeAPIInfo("31"))
> On 2013/06/18 01:58:25, wallyworld wrote:
>> On 2013/06/17 23:42:13, dfc wrote:
>> > s/Fake/Mock, whatever, personal preference.
> 
>> +1 :-)
> 
> Going to stick with Fakes here as Mocks are normally different
> implementations with internal assertions.
> 
> https://codereview.appspot.com/10344044/diff/1/testing/environ.go
> File testing/environ.go (right):
> 
> https://codereview.appspot.com/10344044/diff/1/testing/environ.go#newcode14
> testing/environ.go:14: // EnvironConfig returns a default environment
> configuration.
> On 2013/06/17 23:42:13, dfc wrote:
>> // EnvironConfig returns a default environment configuration suitable
> for
>> testing.
> 
> Done.
> 
> https://codereview.appspot.com/10344044/