Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 103310043: Update HACKING doc.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by bac
Modified:
10 years, 10 months ago
Reviewers:
mp+222790, frankban
Visibility:
Public.

Description

Update HACKING doc. Reference the two different packaging recipes for trusty and beyond and for the pre-trusty series. The packaging branches are now two separate series: lp:juju-quickstart/packaging and lp:juju-quickstart/packaging-pre-trusty. Referencing them in the recipes is cleaner than using bare branch names. Also add a QA step for environments.yaml generation. https://code.launchpad.net/~bac/juju-quickstart/packaging-tweaks/+merge/222790 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update HACKING doc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M HACKING.rst View 1 5 chunks +32 lines, -7 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
10 years, 10 months ago (2014-06-11 12:39:45 UTC) #1
frankban
Hi Brad, thanks for the really nice updates to the documentation! LGTM with a couple ...
10 years, 10 months ago (2014-06-11 13:26:46 UTC) #2
bac
Thanks for the review. One question in-line. https://codereview.appspot.com/103310043/diff/1/HACKING.rst File HACKING.rst (right): https://codereview.appspot.com/103310043/diff/1/HACKING.rst#newcode106 HACKING.rst:106: Repeat above ...
10 years, 10 months ago (2014-06-11 13:31:19 UTC) #3
frankban
On 2014/06/11 13:31:19, bac wrote: > Thanks for the review. One question in-line. > > ...
10 years, 10 months ago (2014-06-11 13:44:03 UTC) #4
bac
10 years, 10 months ago (2014-06-11 14:56:05 UTC) #5
*** Submitted:

Update HACKING doc.

Reference the two different packaging recipes for trusty and beyond and for
the pre-trusty series.

The packaging branches are now two separate series:
lp:juju-quickstart/packaging and lp:juju-quickstart/packaging-pre-trusty.
Referencing them in the recipes is cleaner than using bare branch names.

Also add a QA step for environments.yaml generation.

R=frankban
CC=
https://codereview.appspot.com/103310043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b