Issue 103250045: Resolve port conflicts for cf-loggregator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103250045: Resolve port conflicts for cf-loggregator

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by johnsca

Modified:
9 years, 11 months ago

Reviewers:
mp+222675, benjamin.saller

Visibility:
Public.

Description

Resolve port conflicts for cf-loggregator https://code.launchpad.net/~johnsca/charms/trusty/cf-loggregator/port-conflicts/+merge/222675 (do not edit description out of merge proposal)

Patch Set 2 : Resolve port conflicts for cf-loggregator #

Total comments: 1

Patch Set 3 : Resolve port conflicts for cf-loggregator #

Patch Set 4 : Resolve port conflicts for cf-loggregator #

Patch Set 5 : Resolve port conflicts for cf-loggregator #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -87 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1	1 chunk	+1 line, -7 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View		3 chunks	+17 lines, -6 lines	0 comments	Download
M	hooks/charmhelpers/core/services.py	View		4 chunks	+81 lines, -55 lines	0 comments	Download
M	hooks/config.py	View	1 2 3	1 chunk	+11 lines, -2 lines	0 comments	Download
M	hooks/loggregator-relation-changed	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download
M	metadata.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	templates/loggregator.json	View	1	1 chunk	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, thanks https://codereview.appspot.com/103250045/diff/20001/config.yaml File config.yaml (left): https://codereview.appspot.com/103250045/diff/20001/config.yaml#oldcode11 config.yaml:11: The shared-secret for log clients to use ...

9 years, 11 months ago (2014-06-11 22:25:55 UTC) #3

benjamin.saller

LGTM pending port confirmation mentioned in the other log charm. Looks like they still conflict

9 years, 11 months ago (2014-06-12 16:35:14 UTC) #5

johnsca

9 years, 11 months ago (2014-06-12 18:20:17 UTC) #7

*** Submitted:

Resolve port conflicts for cf-loggregator

R=benjamin.saller
CC=
https://codereview.appspot.com/103250045

Expand All Messages | Collapse All Messages