code review 103240043: goauth2: support client_credentials grant_type

goauth2: support client_credentials grant_type

[mmlb, 2014-07-01 14:32:06]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/goauth2

[gobot, 2014-07-01 14:35:09]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[bradfitz, 2014-07-01 16:06:35]

R=adg

[jbd, 2014-07-07 18:04:42]

Related to https://github.com/golang/oauth2/issues/7.

[adg, 2014-07-07 21:04:06]

https://codereview.appspot.com/103240043/diff/40001/oauth/oauth.go
File oauth/oauth.go (right):

https://codereview.appspot.com/103240043/diff/40001/oauth/oauth.go#newcode320
oauth/oauth.go:320: //AuthenticateClient gets an access Token using the
client_credentials grant
add a space after each //

https://codereview.appspot.com/103240043/diff/40001/oauth/oauth.go#newcode329
oauth/oauth.go:329: return t.updateToken(t.Token,
unwrap this; Go code may be longer than 80 cols
or if you don't like that
v := url.Values{...}
return t.updateToken(t.Token, v)

[mmlb, 2014-07-08 19:39:40]

Hello golang-codereviews@googlegroups.com, adg@golang.org, jbd@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[gobot, 2014-07-08 19:40:58]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[adg, 2014-07-09 04:07:51]

Hey MMendez534 - have you signed the CLA?

http://golang.org/doc/contribute.html#copyright

[mmendez534_gmail.com, 2014-07-09 13:07:38]

Yup I've signed it.


On Wed, Jul 9, 2014 at 12:07 AM, Andrew Gerrand <adg@golang.org> wrote:

> Hey MMendez534 - have you signed the CLA?
>
> http://golang.org/doc/contribute.html#copyright
>

[adg, 2014-07-10 00:49:25]

LGTM

[adg, 2014-07-10 00:50:47]

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=6a3615e294b5
***

goauth2: support client_credentials grant_type

LGTM=adg
R=golang-codereviews, adg, jbd
CC=golang-codereviews
https://codereview.appspot.com/103240043

Committer: Andrew Gerrand <adg@golang.org>