Issue 10322043: code review 10322043: go.net/ipv4: update package documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10322043: code review 10322043: go.net/ipv4: update package documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mikio

Modified:
11 years ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv4: update package documentation - fix more multicasting section as pointed out in go.net/ipv6 review - simplify example codes - do word alignment; s/multicast group address/multicast group/

Patch Set 2 : diff -r b8dd04764dae https://code.google.com/p/go.net #

Patch Set 3 : diff -r b8dd04764dae https://code.google.com/p/go.net #

Total comments: 3

Patch Set 4 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Patch Set 5 : diff -r 3739e7941262 https://code.google.com/p/go.net #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -41 lines)			Patch
	M	ipv4/doc.go	View	1 2 3	8 chunks	+26 lines, -41 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 9 months ago (2013-06-16 10:11:45 UTC) #1

dave_cheney.net

LGTM. https://codereview.appspot.com/10322043/diff/5001/ipv4/doc.go File ipv4/doc.go (right): https://codereview.appspot.com/10322043/diff/5001/ipv4/doc.go#newcode39 ipv4/doc.go:39: // if err := ipv4.NewConn(c).SetTOS(DiffServAF11); err != nil ...

11 years, 9 months ago (2013-06-16 11:52:13 UTC) #2

dave_cheney.net

On 2013/06/16 11:52:13, dfc wrote: > LGTM. > > https://codereview.appspot.com/10322043/diff/5001/ipv4/doc.go > File ipv4/doc.go (right): > ...

11 years, 9 months ago (2013-06-22 02:10:23 UTC) #3

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 9 months ago (2013-06-28 07:27:33 UTC) #4

mikio

11 years, 9 months ago (2013-06-29 01:25:56 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=7ffc008ad4b1&repo=net ***

go.net/ipv4: update package documentation

- fix more multicasting section as pointed out in go.net/ipv6 review
- simplify example codes
- do word alignment; s/multicast group address/multicast group/

R=dave
CC=golang-dev
https://codereview.appspot.com/10322043

https://codereview.appspot.com/10322043/diff/5001/ipv4/doc.go
File ipv4/doc.go (right):

https://codereview.appspot.com/10322043/diff/5001/ipv4/doc.go#newcode142
ipv4/doc.go:142: // group addresses.  For example, a UDP listener with port 1024
might
On 2013/06/16 11:52:13, dfc wrote:
> ... may join multiple multicast {groups,addresses} // pick one

Done.

Expand All Messages | Collapse All Messages