Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(522)

Issue 10309044: Fix drag problems on service creation

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by matthew.scott
Modified:
10 years, 9 months ago
Reviewers:
teknico, jeff.pihach, mp+170640
Visibility:
Public.

Description

Fix drag problems on service creation This bug affected FF and Chrome, causing relation lines to be mis-aligned and services to jump when dragged. I believe it was due to lingering attributes on the service boxes after creation. To QA, add MySQL and Wordpress, relate them, then drag them around a bunch. The relation line should follow the service blocks, and the service blocks shouldn't jump to any position when you start to drag them. https://code.launchpad.net/~makyo/juju-gui/ff-annotations-1192596/+merge/170640 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix drag problems on service creation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
10 years, 9 months ago (2013-06-20 14:44:32 UTC) #1
jeff.pihach
LGTM Thanks. Please create a card to fix the service jumping issue that those were ...
10 years, 9 months ago (2013-06-20 15:03:28 UTC) #2
teknico
LGTM
10 years, 9 months ago (2013-06-20 15:03:55 UTC) #3
matthew.scott
10 years, 9 months ago (2013-06-20 15:11:32 UTC) #4
*** Submitted:

Fix drag problems on service creation

This bug affected FF and Chrome, causing relation lines to be mis-aligned and
services to jump when dragged.  I believe it was due to lingering attributes on
the service boxes after creation.  To QA, add MySQL and Wordpress, relate them,
then drag them around a bunch.  The relation line should follow the service
blocks, and the service blocks shouldn't jump to any position when you start to
drag them.

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/10309044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b