Issue 102920050: code review 102920050: go1.3rc1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 102920050: code review 102920050: go1.3rc1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by adg

Modified:
9 years, 10 months ago

Reviewers:
gobot, minux

CC:
golang-codereviews, minux

Visibility:
Public.

Description

go1.3rc1

Patch Set 1 #

Patch Set 2 : diff -r 04f10d28eaae https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	A	VERSION	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 10 months ago (2014-06-02 03:06:20 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=9d5451df4e53 *** go1.3rc1 LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://codereview.appspot.com/102920050

9 years, 10 months ago (2014-06-02 04:35:00 UTC) #3

gobot

This CL appears to have broken the nacl-amd64p32 builder. See http://build.golang.org/log/c67c7b50123d3e9e55fa8c23d252b6b7ec498f82

9 years, 10 months ago (2014-06-02 04:43:00 UTC) #4

adg

9 years, 10 months ago (2014-06-02 04:45:48 UTC) #5

On 2 June 2014 14:42, <gobot@golang.org> wrote:

> This CL appears to have broken the nacl-amd64p32 builder.
> See http://build.golang.org/log/c67c7b50123d3e9e55fa8c23d252b6b7ec498f82
>

Flaky?

Expand All Messages | Collapse All Messages