Issue 102770044: GoogleCredential pass Private Key Id.

Issue 102770044: GoogleCredential pass Private Key Id. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Anthony Moore

Modified:
12 years, 4 months ago

Reviewers:
beaton, Orest

CC:
wonderfly

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Patch Set 2 : Fixing duplicate 'the' in doc comments. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -13 lines)			Patch
	M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java	View	1	16 chunks	+63 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Orest

LGTM https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java (right): https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java#newcode287 google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:287: * ID of private key to use with ...

12 years, 4 months ago (2014-05-27 21:56:50 UTC) #2

Anthony Moore

12 years, 4 months ago (2014-06-04 18:27:58 UTC) #4

Fixed the doc comment errors.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
File
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java
(right):

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:287:
* ID of private key to use with the the service account flow or {@code null} if
not using the
On 2014/05/27 21:56:50, Orest wrote:
> Double 'the'.
> Please get rid of one of them.

Done. Fixed all instances of this error in the file, about 12 of them.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:436:
* Returns the ID of the private key to use with the the service account flow or
{@code null} if
On 2014/05/27 21:56:50, Orest wrote:
> Same double 'the' here.

Done.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:509:
/** Id of the private key to use with the the service account flow or {@code
null} for none. */
On 2014/05/27 21:56:50, Orest wrote:
> Same double 'the' here.

Done.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:509:
/** Id of the private key to use with the the service account flow or {@code
null} for none. */
On 2014/05/27 21:56:50, Orest wrote:
> Same double 'the' here.

Done.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:654:
* Returns the id of the private key to use with the the service account flow or
{@code null}
On 2014/05/27 21:56:50, Orest wrote:
> Same double 'the' here.

Done.

https://codereview.appspot.com/102770044/diff/1/google-api-client/src/main/ja...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:664:
* Sets the id of the private key to use with the the service account flow or
{@code null} for
On 2014/05/27 21:56:50, Orest wrote:
> Same double 'the' here.

Done.

Expand All Messages | Collapse All Messages