Issue 10273044: Move environs.Instance into own package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10273044: Move environs.Instance into own package.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by thumper

Modified:
10 years, 10 months ago

Reviewers:
mp+169325, jameinel, fwereade

Visibility:
Public.

Description

Move environs.Instance into own package. Instances are the realizations of state Machines, and could be either containers or environ provider instances. https://code.launchpad.net/~thumper/juju-core/instance-instance/+merge/169325 Requires: https://code.launchpad.net/~thumper/juju-core/fix-test-creating-file-in-tree/+merge/169324 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+212 lines, -185 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/status.go	View	3 chunks	+4 lines, -3 lines	1 comment	Download
M	environs/azure/environ.go	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	environs/azure/instance.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/dummy/environs.go	View	16 chunks	+20 lines, -19 lines	0 comments	Download
M	environs/ec2/ec2.go	View	17 chunks	+29 lines, -28 lines	0 comments	Download
M	environs/ec2/export_test.go	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	environs/ec2/live_test.go	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	environs/interface.go	View	5 chunks	+6 lines, -35 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	9 chunks	+9 lines, -8 lines	0 comments	Download
M	environs/jujutest/tests.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	environs/maas/environ.go	View	10 chunks	+12 lines, -11 lines	0 comments	Download
M	environs/maas/environ_test.go	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	environs/maas/instance.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/openstack/local_test.go	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	environs/openstack/provider.go	View	20 chunks	+29 lines, -28 lines	0 comments	Download
M	environs/openstack/provider_test.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download
A	instance/instance.go	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	juju/testing/conn.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	worker/provisioner/broker.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	worker/provisioner/provisioner_task.go	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM. For the future, consider instance.Broker as well as instance.Id... https://codereview.appspot.com/10273044/diff/1/cmd/juju/status.go File cmd/juju/status.go (right): https://codereview.appspot.com/10273044/diff/1/cmd/juju/status.go#newcode46 ...

10 years, 10 months ago (2013-06-14 07:52:17 UTC) #2

Assuming this is just a mechanical rename
LGTM

Expand All Messages | Collapse All Messages