Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1089)

Issue 102620044: code review 102620044: runtime: make runtime·usleep and runtime·osyield call...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by aram
Modified:
10 years, 11 months ago
Reviewers:
rsc, dave
CC:
minux1, rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

runtime: make runtime·usleep and runtime·osyield callable from cgo callback runtime·usleep and runtime·osyield fall back to calling an assembly wrapper for the libc functions in the absence of a m, so they can be called in cgo callback context.

Patch Set 1 #

Patch Set 2 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 3 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 4 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 5 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 6 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 7 : diff -r 85b6bbfa558b https://code.google.com/p/go #

Patch Set 8 : diff -r 85b6bbfa558b https://code.google.com/p/go #

Patch Set 9 : diff -r 85b6bbfa558b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -3 lines) Patch
M src/pkg/runtime/os_solaris.c View 1 2 3 4 5 6 2 chunks +15 lines, -3 lines 0 comments Download
M src/pkg/runtime/sys_solaris_amd64.s View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 9
aram
Hello minux1 (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2014-06-22 14:40:06 UTC) #1
aram
Hello minux.ma@gmail.com (cc: dfc, golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2014-06-22 14:41:23 UTC) #2
aram
Hello minux.ma@gmail.com (cc: dave@cheney.net, golang-codereviews@googlegroups.com, rsc), Please take another look.
10 years, 11 months ago (2014-06-22 14:41:52 UTC) #3
aram
Ugh, is it possible to --cc and -r everybody in a single hg mail invocation? ...
10 years, 11 months ago (2014-06-22 14:42:59 UTC) #4
rsc
Yes, -cc a,b,c
10 years, 11 months ago (2014-06-26 14:59:56 UTC) #5
rsc
LGTM This is getting worse and worse. Please make sure the damage remains contained to ...
10 years, 11 months ago (2014-06-26 15:01:54 UTC) #6
aram
Please don't submit yet, TLS changes broke it, working on it.
10 years, 11 months ago (2014-07-02 11:30:08 UTC) #7
aram
Fixed, good to go.
10 years, 11 months ago (2014-07-02 12:53:13 UTC) #8
dave_cheney.net
10 years, 11 months ago (2014-07-03 01:36:23 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=04c9a977b540 ***

runtime: make runtime·usleep and runtime·osyield callable from cgo callback

runtime·usleep and runtime·osyield fall back to calling an
assembly wrapper for the libc functions in the absence of a m,
so they can be called in cgo callback context.

LGTM=rsc
R=minux.ma, rsc
CC=dave, golang-codereviews
https://codereview.appspot.com/102620044

Committer: Dave Cheney <dave@cheney.net>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b