code review 10259043: runtime/race: remove now unused step parameter from ran...

runtime/race: remove now unused step parameter from range access functions

[dvyukov, 2013-06-13 12:20:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dave_cheney.net, 2013-06-13 12:25:28]

LGTM.

https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.go
File src/pkg/runtime/race/race.go (right):

https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.g...
src/pkg/runtime/race/race.go:61: C.long(sz) /*step is unused*/, 0,
unsafe.Pointer(pc))
can you move the comma to the left of the comment so it is clear the comment
refers to the 0. Or maybe #define UNUSED 0 or something.

[dvyukov, 2013-06-13 12:28:04]

On Thu, Jun 13, 2013 at 4:25 PM,  <dave@cheney.net> wrote:
> LGTM.
>
>
>
https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.go
> File src/pkg/runtime/race/race.go (right):
>
>
https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.g...
> src/pkg/runtime/race/race.go:61: C.long(sz) /*step is unused*/, 0,
> unsafe.Pointer(pc))
> can you move the comma to the left of the comment so it is clear the
> comment refers to the 0. Or maybe #define UNUSED 0 or something.


Humm... is it fmt bug? Try to reformat this:
http://play.golang.org/p/yFVT9LrK67

[dvyukov, 2013-06-13 12:29:01]

On 2013/06/13 12:25:28, dfc wrote:
> LGTM.
> 
> https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.go
> File src/pkg/runtime/race/race.go (right):
> 
>
https://codereview.appspot.com/10259043/diff/3007/src/pkg/runtime/race/race.g...
> src/pkg/runtime/race/race.go:61: C.long(sz) /*step is unused*/, 0,
> unsafe.Pointer(pc))
> can you move the comma to the left of the comment so it is clear the comment
> refers to the 0. Or maybe #define UNUSED 0 or something.

Done

[dvyukov, 2013-06-13 12:38:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=fcabd133a054 ***

runtime/race: remove now unused step parameter from range access functions

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/10259043