code review 10258043: crypto/x509: Added RFC 5280, section 4.2.1.14 to parseC...

crypto/x509: Added RFC 5280, section 4.2.1.14 to parseCertificate and buildExtensions
Support for CRL Distribution Points

[Paul van Brouwershaven, 2013-06-13 11:03:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[agl1, 2013-06-13 15:53:06]

LGTM with nit.

https://codereview.appspot.com/10258043/diff/5001/src/pkg/crypto/x509/x509.go
File src/pkg/crypto/x509/x509.go (right):

https://codereview.appspot.com/10258043/diff/5001/src/pkg/crypto/x509/x509.go...
src/pkg/crypto/x509/x509.go:666: type crlDistributionPoints []distributionPoint
It would be nice to remove this type - it adds very little.

[Paul van Brouwershaven, 2013-06-14 07:14:12]

Hello golang-dev@googlegroups.com, agl@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[Paul van Brouwershaven, 2013-06-15 09:44:21]

https://codereview.appspot.com/10258043/diff/5001/src/pkg/crypto/x509/x509.go
File src/pkg/crypto/x509/x509.go (right):

https://codereview.appspot.com/10258043/diff/5001/src/pkg/crypto/x509/x509.go...
src/pkg/crypto/x509/x509.go:666: type crlDistributionPoints []distributionPoint
On 2013/06/13 15:53:06, agl1 wrote:
> It would be nice to remove this type - it adds very little.

Done.

[agl1, 2013-06-17 20:58:21]

LGTM.

Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright

[Paul van Brouwershaven, 2013-06-17 21:29:02]

On 2013/06/17 20:58:21, agl1 wrote:
> LGTM.
> 
> Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright

Just signed

[bradfitz, 2013-06-17 21:42:25]

On Mon, Jun 17, 2013 at 2:29 PM, <paul@vanbrouwershaven.com> wrote:

> On 2013/06/17 20:58:21, agl1 wrote:
>
>> LGTM.
>>
>
>  Have you signed the ICLA?
>>
>
http://golang.org/doc/**contribute.html#copyright<http://golang.org/doc/contr...
>
> Just signed


I can't find it under your name or email address.

Did you do the online form, or fax it?

[Paul van Brouwershaven, 2013-06-17 21:46:27]

The online form, just a few minutes before sending the previous mail.

I can fill the form again if you want?


On Mon, Jun 17, 2013 at 11:42 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> On Mon, Jun 17, 2013 at 2:29 PM, <paul@vanbrouwershaven.com> wrote:
>
>> On 2013/06/17 20:58:21, agl1 wrote:
>>
>>> LGTM.
>>>
>>
>>  Have you signed the ICLA?
>>>
>>
http://golang.org/doc/**contribute.html#copyright<http://golang.org/doc/contr...
>>
>> Just signed
>
>
> I can't find it under your name or email address.
>
> Did you do the online form, or fax it?
>
>


-- 
Regards,

Paul van Brouwershaven

http://linkedin.com/in/pvanbrouwershaven
http://facebook.com/p.vanbrouwershaven
http://twitter.com/vanbroup

[bradfitz, 2013-06-17 21:48:20]

I see an entirely blank submission at 6/17/2013 14:27:54.  Maybe that was
you.

Yes, please resubmit.



On Mon, Jun 17, 2013 at 2:46 PM, Paul van Brouwershaven <
paul@vanbrouwershaven.com> wrote:

> The online form, just a few minutes before sending the previous mail.
>
> I can fill the form again if you want?
>
>
> On Mon, Jun 17, 2013 at 11:42 PM, Brad Fitzpatrick
<bradfitz@golang.org>wrote:
>
>> On Mon, Jun 17, 2013 at 2:29 PM, <paul@vanbrouwershaven.com> wrote:
>>
>>> On 2013/06/17 20:58:21, agl1 wrote:
>>>
>>>> LGTM.
>>>>
>>>
>>>  Have you signed the ICLA?
>>>>
>>>
http://golang.org/doc/**contribute.html#copyright<http://golang.org/doc/contr...
>>>
>>> Just signed
>>
>>
>> I can't find it under your name or email address.
>>
>> Did you do the online form, or fax it?
>>
>>
>
>
> --
> Regards,
>
> Paul van Brouwershaven
>
> http://linkedin.com/in/pvanbrouwershaven
> http://facebook.com/p.vanbrouwershaven
> http://twitter.com/vanbroup
>

[Paul van Brouwershaven, 2013-06-17 21:53:44]

Done

I think this empty was caused by switching to Incognito mode in Chrome as
the form is not supporting multiple active accounts.


On Mon, Jun 17, 2013 at 11:48 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> I see an entirely blank submission at 6/17/2013 14:27:54.  Maybe that was
> you.
>
> Yes, please resubmit.
>
>
>
> On Mon, Jun 17, 2013 at 2:46 PM, Paul van Brouwershaven <
> paul@vanbrouwershaven.com> wrote:
>
>> The online form, just a few minutes before sending the previous mail.
>>
>> I can fill the form again if you want?
>>
>>
>> On Mon, Jun 17, 2013 at 11:42 PM, Brad Fitzpatrick
<bradfitz@golang.org>wrote:
>>
>>> On Mon, Jun 17, 2013 at 2:29 PM, <paul@vanbrouwershaven.com> wrote:
>>>
>>>> On 2013/06/17 20:58:21, agl1 wrote:
>>>>
>>>>> LGTM.
>>>>>
>>>>
>>>>  Have you signed the ICLA?
>>>>>
>>>>
http://golang.org/doc/**contribute.html#copyright<http://golang.org/doc/contr...
>>>>
>>>> Just signed
>>>
>>>
>>> I can't find it under your name or email address.
>>>
>>> Did you do the online form, or fax it?
>>>
>>>
>>
>>
>> --
>> Regards,
>>
>> Paul van Brouwershaven
>>
>> http://linkedin.com/in/pvanbrouwershaven
>> http://facebook.com/p.vanbrouwershaven
>> http://twitter.com/vanbroup
>>
>
>


-- 
Regards,

Paul van Brouwershaven

http://linkedin.com/in/pvanbrouwershaven
http://facebook.com/p.vanbrouwershaven
http://twitter.com/vanbroup

[bradfitz, 2013-06-17 21:56:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=eec7eca4b11a ***

crypto/x509: Added RFC 5280, section 4.2.1.14 to parseCertificate and
buildExtensions
Support for CRL Distribution Points

R=golang-dev, agl, bradfitz
CC=golang-dev
https://codereview.appspot.com/10258043

Committer: Brad Fitzpatrick <bradfitz@golang.org>