code review 10255047: cmd/gc: don't attempt to generate wrappers for blank in...

cmd/gc: don't attempt to generate wrappers for blank interface methods

Fixes issue 5691.

[ality, 2013-06-14 00:24:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-06-17 20:27:59]

R=rsc

[DMorsing, 2013-06-20 17:00:08]

LGTM

[rsc, 2013-06-21 16:57:26]

Thanks very much for fixing this, but not lgtm yet.

There are lots of things that could go wrong here. The test checks that the
compiler no longer crashes, but it should instead check that the generated
program is actually correct. I'd like check that

type I1 interface { _() }
type I2 interface { M(); _() }

are not satisfiable by anything. There should be one 'errorcheck' test for
static conversions and one 'run' test for panics in dynamic conversions.

I suggest adding to test/interface/explicit.go and test/interface/fail.go.

[ality, 2013-06-27 11:27:46]

rsc@golang.org once said:
> Thanks very much for fixing this, but not lgtm yet.
> 
> There are lots of things that could go wrong here. The test checks that
> the compiler no longer crashes, but it should instead check that the
> generated program is actually correct. I'd like check that
> 
> type I1 interface { _() }
> type I2 interface { M(); _() }
> 
> are not satisfiable by anything. There should be one 'errorcheck' test
> for static conversions and one 'run' test for panics in dynamic
> conversions.
> 
> I suggest adding to test/interface/explicit.go and
> test/interface/fail.go.

Thanks for looking at this.

I've been busy but I can add the requested tests this weekend.

Cheers,
  Anthony

[ality, 2013-07-20 07:29:16]

Hello golang-dev@googlegroups.com, bradfitz@golang.org,
daniel.morsing@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-08-01 21:07:17]

LGTM

[r, 2013-08-19 01:53:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=a503fae0e05a ***

cmd/gc: don't attempt to generate wrappers for blank interface methods

Fixes issue 5691.

R=golang-dev, bradfitz, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/10255047

Committer: Rob Pike <r@golang.org>