Issue 10253049: Fixes #1190653 properly ignore /login as charmid

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10253049: Fixes #1190653 properly ignore /login as charmid

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
curtis, jeff.pihach, mp+169266

Visibility:
Public.

Description

Fixes #1190653 properly ignore /login as charmid - The /login/ url was getting two matches to the regex used to detect if this was a charmid or just a /something string that should be ignored. It was matching login/ and n/. - Rather than a regex, actually remove the start/trail '/' and split on any other /. If there's exactly two parts then this is a charmid we should try to match and display. https://code.launchpad.net/~rharding/juju-gui/logout-404-1190653/+merge/169266 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes #1190653 properly ignore /login as charmid #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/test_browser_app.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

curtis

Thank you for the fix. I also think the rule is easier to read now. ...

10 years, 10 months ago (2013-06-13 18:05:46 UTC) #2

jeff.pihach

LGTM Thanks for this fix! Just a small comment request. https://codereview.appspot.com/10253049/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/10253049/diff/1/app/subapps/browser/browser.js#newcode756 ...

10 years, 10 months ago (2013-06-13 18:07:23 UTC) #3

rharding

10 years, 10 months ago (2013-06-13 18:13:06 UTC) #4

*** Submitted:

Fixes #1190653 properly ignore /login as charmid

- The /login/ url was getting two matches to the regex used to detect if this
was a charmid or just a /something string that should be ignored. It was
matching login/ and n/.
- Rather than a regex, actually remove the start/trail '/' and split on any
other /. If there's exactly two parts then this is a charmid we should try to
match and display.

R=curtis, jeff.pihach
CC=
https://codereview.appspot.com/10253049

Expand All Messages | Collapse All Messages