Issue 10246044: Fixes #1190265 move config to config.options

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10246044: Fixes #1190265 move config to config.options

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
jeff.pihach, mp+169247, gary.poster

Visibility:
Public.

Description

Fixes #1190265 move config to config.options - It appears at some point the Charm model moved the yaml config from a pure config ATTR to a config.options. - This nests our config in the BrowserCharm when adding a charm to the environment. https://code.launchpad.net/~rharding/juju-gui/missing-config-1190265/+merge/169247 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes #1190265 move config to config.options #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 10 months ago (2013-06-13 16:38:07 UTC) #4

*** Submitted:

Fixes #1190265 move config to config.options

- It appears at some point the Charm model moved the yaml config from a pure
config ATTR to a config.options.
- This nests our config in the BrowserCharm when adding a charm to the
environment.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/10246044

Expand All Messages | Collapse All Messages