Issue 10245048: code review 10245048: crypto/x509: Added RFC 5280, section 4.2.2.1 Authority ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10245048: code review 10245048: crypto/x509: Added RFC 5280, section 4.2.2.1 Authority ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Paul van Brouwershaven

Modified:
11 years, 8 months ago

Reviewers:
agl1

CC:
agl, agl1, gobot, golang-dev

Visibility:
Public.

Description

crypto/x509: Added RFC 5280, section 4.2.2.1 Authority Information Access

Patch Set 1 : diff -r e274daf75c26 https://code.google.com/p/go #

Total comments: 4

Patch Set 2 : diff -r 4f5aa82dafa2 https://code.google.com/p/go #

Patch Set 3 : diff -r 4f5aa82dafa2 https://code.google.com/p/go #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -1 line)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1 2	5 chunks	+57 lines, -1 line	0 comments	Download
	M	src/pkg/crypto/x509/x509_test.go	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Paul van Brouwershaven

Hello golang-dev@googlegroups.com (cc: agl@golang.org), I'd like you to review this change to https://code.google.com/p/go

11 years, 9 months ago (2013-06-14 07:40:45 UTC) #1

agl1

LGTM with nits. Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright https://codereview.appspot.com/10245048/diff/5001/src/pkg/crypto/x509/x509.go File src/pkg/crypto/x509/x509.go (right): https://codereview.appspot.com/10245048/diff/5001/src/pkg/crypto/x509/x509.go#newcode965 src/pkg/crypto/x509/x509.go:965: ...

11 years, 9 months ago (2013-06-14 19:16:29 UTC) #3

Paul van Brouwershaven

Hello agl@chromium.org, agl@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com), Please take another look.

11 years, 9 months ago (2013-06-26 15:32:10 UTC) #4

Paul van Brouwershaven

Now also updated the OIDs at the bottom when creating the extension.

11 years, 9 months ago (2013-06-26 15:41:51 UTC) #5

agl1

11 years, 9 months ago (2013-06-27 21:16:39 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=a9e823edde19 ***

crypto/x509: Added RFC 5280, section 4.2.2.1 Authority Information Access

R=agl, agl
CC=gobot, golang-dev
https://codereview.appspot.com/10245048

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages