Issue 10244044: Ignore Emacs auto-save files in lbox pre-checks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10244044: Ignore Emacs auto-save files in lbox pre-checks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by Danilo

Modified:
10 years, 10 months ago

Reviewers:
mp+169183, gz, fwereade

Visibility:
Public.

Description

Ignore Emacs auto-save files in lbox pre-checks Emacs auto-save files are named '.#...', so if you have a storage.go file open, Emacs will keep a '.#storage.go' file around for auto-saving. However, the way we pass arguments to gofmt means that '.#' will not be properly escaped and gofmt will not be able to open the file, thus stopping an lbox propose. This change removes any filenames beginning with '.#' with a simple grep. https://code.launchpad.net/~danilo/juju-core/lbox-check-emacs/+merge/169183 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ignore Emacs auto-save files in lbox pre-checks #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	.lbox.check	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

LGTM though am disappointed you dindn't bundle it all into the find command. :)

10 years, 10 months ago (2013-06-14 12:27:32 UTC) #3

Still LGTM, I'd go ahead and try out landing with the bot.

Expand All Messages | Collapse All Messages