Issue 10242045: code review 10242045: runtime: remove unused moreframesize_minalloc field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10242045: code review 10242045: runtime: remove unused moreframesize_minalloc field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dvyukov

Modified:
12 years ago

Reviewers:
dave

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

runtime: remove unused moreframesize_minalloc field It was used to request large stack segment for GC when it was running not on g0. Now GC is running on g0 with large stack, and it is not needed anymore.

Patch Set 1 #

Patch Set 2 : diff -r 52d53d0e177e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 52d53d0e177e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 71375a634b9a https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	src/pkg/runtime/runtime.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/stack.c	View	1	2 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years ago (2013-06-14 08:40:38 UTC) #1

dave_cheney.net

On 2013/06/14 08:40:38, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

12 years ago (2013-06-15 09:40:43 UTC) #2

dvyukov

12 years ago (2013-06-15 12:04:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b5808d92a1c7 ***

runtime: remove unused moreframesize_minalloc field
It was used to request large stack segment for GC
when it was running not on g0.
Now GC is running on g0 with large stack,
and it is not needed anymore.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/10242045

Expand All Messages | Collapse All Messages