Issue 10241046: Dark header style change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10241046: Dark header style change

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by jeff.pihach

Modified:
10 years, 10 months ago

Reviewers:
gary.poster, mp+169300

Visibility:
Public.

Description

Dark header style change Commiting Huw's markup and style changes for the header I also changed the styles for the right configuration panel to better blend with the new header. I also put a bandaid on the right configuration panel height issue, it doesn't recalculate on resize, and it's a 'magic number' fix. https://code.launchpad.net/~hatch/juju-gui/header-design/+merge/169300 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Dark header style change #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -172 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	2 chunks	+5 lines, -2 lines	0 comments	Download
A	app/assets/images/header_notification_centre.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/header_notification_left.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/header_notification_right.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/juju_logo_dark.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/index.html	View	1 chunk	+29 lines, -37 lines	0 comments	Download
M	app/templates/notifications.handlebars	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	app/views/charm-panel.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	app/views/notifications.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/browser/main.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/browser/minimized.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/browser/mixins.less	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	lib/views/stylesheet.less	View	6 chunks	+110 lines, -105 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jeff.pihach

10 years, 10 months ago (2013-06-13 22:28:20 UTC) #3

*** Submitted:

Dark header style change

Commiting Huw's markup and style changes for the header
I also changed the styles for the right configuration
panel to better blend with the new header.
I also put a bandaid on the right configuration panel
height issue, it doesn't recalculate on resize, and it's
a 'magic number' fix.

R=gary.poster
CC=
https://codereview.appspot.com/10241046

Expand All Messages | Collapse All Messages