Removal of right charm search panel

Removal of right charm search panel

This branch is the first step towards removing the right panel
entirely. All deployments are now done via the charm browser
and only ghost configuration is done by the right panel.

https://code.launchpad.net/~hatch/juju-gui/remove-charmsearch/+merge/169054

(do not edit description out of merge proposal)

[jeff.pihach, 2013-06-12 20:53:52]

Please take a look.

[gary.poster, 2013-06-12 21:02:24]

Holy smoke that's a lot of deleted code! yay! :-)

Let me do some qa before I bless it.  I still don't see why we need
setActivePanelName, but I also don't care a lot under the circumstances.

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:725: function setActivePanelName(name) {
I don't quite see why we even need this, now that there is only one pane.  Maybe
I'll see why later.

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:769: app.db.services.each(function(service) {
A bit heavy handed, but under the circumstances I'm fine with it. :-)

https://codereview.appspot.com/10241043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/10241043/diff/1/lib/views/stylesheet.less#newc...
lib/views/stylesheet.less:1065: color: #515050;
Is this the fix for the invisible cancel button?  If so, thank you. :-)

[jeff.pihach, 2013-06-12 21:05:36]

Thanks for the review!

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:725: function setActivePanelName(name) {
It's only here to allow me to set an active panel name during testing.

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:769: app.db.services.each(function(service) {
Yeah I thought so too but this won't be around for long. :)

https://codereview.appspot.com/10241043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/10241043/diff/1/lib/views/stylesheet.less#newc...
lib/views/stylesheet.less:1065: color: #515050;
You bet! :-)

[gary.poster, 2013-06-12 21:15:53]

LGTM with addressing the one qa issue I found.  If you start with improv (I used
large fwiw) and then deploy a charm, then the ghost will go one place but the
new confirmed service will go someplace else.  Once this is addressed, please
land this with my thanks.

[matthew.scott, 2013-06-12 21:21:17]

LGTM with Gary's concerns from IRC addressed.

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/10241043/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:769: app.db.services.each(function(service) {
On 2013/06/12 21:02:24, gary.poster wrote:
> A bit heavy handed, but under the circumstances I'm fine with it. :-)

Agreed; deploying is an async op, so these could stay pending in a long time -
you close the charm browser, they disappear, then show up again later.  That's
the current behavior now, too, but we haven't had bundles in the past.  I'm fine
with it, too, so long as we take this into account when bundles happen and not
use the pending flag for anything else :)

[jeff.pihach, 2013-06-13 16:17:32]

Please take a look.

[jeff.pihach, 2013-06-13 16:46:55]

*** Submitted:

Removal of right charm search panel

This branch is the first step towards removing the right panel
entirely. All deployments are now done via the charm browser
and only ghost configuration is done by the right panel.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/10241043