Issue 10238046: Restore follow_redirects after mediadownload is done.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10238046: Restore follow_redirects after mediadownload is done. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by jcgregorio_google

Modified:
13 years, 3 months ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Restore follow_redirects after mediadownload is done. Fixes issue 280. https://code.google.com/p/google-api-python-client/issues/detail?id=280

Patch Set 2 : rename #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	apiclient/http.py	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
	M	tests/test_http.py	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/10238046/diff/1/apiclient/http.py File apiclient/http.py (right): https://codereview.appspot.com/10238046/diff/1/apiclient/http.py#newcode508 apiclient/http.py:508: self._old_follow_redirects = request.http.follow_redirects Suggest _original_follow_redirects instead of _old_follow_redirects

13 years, 3 months ago (2013-06-13 15:49:54 UTC) #2

jcgregorio_google

https://codereview.appspot.com/10238046/diff/1/apiclient/http.py File apiclient/http.py (right): https://codereview.appspot.com/10238046/diff/1/apiclient/http.py#newcode508 apiclient/http.py:508: self._old_follow_redirects = request.http.follow_redirects On 2013/06/13 15:49:55, dhermes wrote: > ...

13 years, 3 months ago (2013-06-13 18:46:15 UTC) #3

jcgregorio_google

13 years, 3 months ago (2013-06-13 18:48:47 UTC) #4

On 2013/06/13 18:46:15, jcgregorio_google wrote:
> https://codereview.appspot.com/10238046/diff/1/apiclient/http.py
> File apiclient/http.py (right):
> 
> https://codereview.appspot.com/10238046/diff/1/apiclient/http.py#newcode508
> apiclient/http.py:508: self._old_follow_redirects =
> request.http.follow_redirects
> On 2013/06/13 15:49:55, dhermes wrote:
> > Suggest _original_follow_redirects instead of _old_follow_redirects
> 
> Done.

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=6a9f2cfb7c...

Expand All Messages | Collapse All Messages