Issue 10237050: code review 10237050: net/http: Transport should return an error when respons...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10237050: code review 10237050: net/http: Transport should return an error when respons... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by bradfitz

Modified:
10 years, 10 months ago

Reviewers:
kevlar, r

CC:
golang-dev, kevlar, r

Visibility:
Public.

Description

net/http: Transport should return an error when response body ends early If a server response contains a Content-Length and the body is short, the Transport should end in io.ErrUnexpectedEOF, not io.EOF. Fixes issue 5738

Patch Set 1 #

Patch Set 2 : diff -r 0581827a7481 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0581827a7481 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 33c84d77a5a4 https://go.googlecode.com/hg/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -5 lines)			Patch
	M	src/pkg/net/http/response_test.go	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/transfer.go	View	1	1 chunk	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 10 months ago (2013-06-21 18:43:35 UTC) #1

kevlar

On 2013/06/21 18:43:35, bradfitz wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

10 years, 10 months ago (2013-06-24 20:17:09 UTC) #2

bradfitz

10 years, 10 months ago (2013-06-24 20:27:59 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=41134e67106d ***

net/http: Transport should return an error when response body ends early

If a server response contains a Content-Length and the body is short,
the Transport should end in io.ErrUnexpectedEOF, not io.EOF.

Fixes issue 5738

R=golang-dev, kevlar, r
CC=golang-dev
https://codereview.appspot.com/10237050

Expand All Messages | Collapse All Messages