code review 10230043: go.crypto/ssh/test: Run sshd with -e, so the debug outp...

go.crypto/ssh/test: Run sshd with -e, so the debug output goes onto stderr.

[hanwen-google, 2013-06-12 14:02:06]

Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2013-06-16 12:40:31]

https://codereview.appspot.com/10230043/diff/5001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):

https://codereview.appspot.com/10230043/diff/5001/ssh/test/test_unix_test.go#...
ssh/test/test_unix_test.go:67: log.Fatalf("LookPath(\"sshd\"): %v", err)
I don't think this is the right solution. I think a better choice would be a
t.Skipf(...) in Dial/TryDial.

[hanwen-google, 2013-06-17 12:30:46]

https://codereview.appspot.com/10230043/diff/5001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):

https://codereview.appspot.com/10230043/diff/5001/ssh/test/test_unix_test.go#...
ssh/test/test_unix_test.go:67: log.Fatalf("LookPath(\"sshd\"): %v", err)
On 2013/06/16 12:40:31, dfc wrote:
> I don't think this is the right solution. I think a better choice would be a
> t.Skipf(...) in Dial/TryDial.

Done.

[agl1, 2013-06-17 13:49:09]

LGTM.

[dave_cheney.net, 2013-06-18 11:50:23]

LGTM.

https://codereview.appspot.com/10230043/diff/11001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):

https://codereview.appspot.com/10230043/diff/11001/ssh/test/test_unix_test.go...
ssh/test/test_unix_test.go:66: if err != nil {
I changed this to move the LookPath to Dial.

[dave_cheney.net, 2013-06-18 11:51:15]

*** Submitted as
https://code.google.com/p/go/source/detail?r=2f8b5b472968&repo=crypto ***

go.crypto/ssh/test: Run sshd with -e, so the debug output goes onto stderr.

R=dave, agl
CC=golang-dev
https://codereview.appspot.com/10230043

Committer: Dave Cheney <dave@cheney.net>

[hanwen-google, 2013-06-18 12:43:54]

*** Abandoned ***