Fixes #1190063 forcing editoral to reload on back.

Fixes #1190063 forcing editoral to reload on back.

- _shouldShowEditorial doesn't take into account the case that the viewmode
hasn't changed, but search has been changed.

https://code.launchpad.net/~rharding/juju-gui/category-back-1190063/+merge/168993

(do not edit description out of merge proposal)

[rharding, 2013-06-12 16:16:00]

Please take a look.

[rharding, 2013-06-12 16:20:02]

Please take a look.

[jeff.pihach, 2013-06-12 16:27:48]

LGTM with a question about the method

https://codereview.appspot.com/10227045/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/10227045/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:184: _shouldShowEditorial: function() {
I'm a little confused by this method. It returns weather they should show the
editorial but it also has side effects? re _hasStateChanged

[rharding, 2013-06-12 16:32:45]

Reply below.

https://codereview.appspot.com/10227045/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/10227045/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:184: _shouldShowEditorial: function() {
On 2013/06/12 16:27:48, jeff.pihach wrote:
> I'm a little confused by this method. It returns weather they should show the
> editorial but it also has side effects? re _hasStateChanged

_hasStateChanged doesn't change state. It just determines if that part of state
has changed. It returns a bool true/false for the part of the state checked.

So in this case, _hasStateChanged is asking "was the last state viewmode
different than the current one?"

[matthew.scott, 2013-06-12 16:52:46]

LGTM - thanks for the fix.

[rharding, 2013-06-12 17:14:07]

*** Submitted:

Fixes #1190063 forcing editoral to reload on back.

- _shouldShowEditorial doesn't take into account the case that the viewmode
hasn't changed, but search has been changed.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/10227045