Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(521)

Issue 10227043: code review 10227043: cmd/gc: fix race detector on tail-call wrappers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
dvyukov
CC:
golang-dev, minux1, DMorsing
Visibility:
Public.

Description

cmd/gc: fix race detector on tail-call wrappers (By not using the tail-call wrappers when the race detector is enabled.)

Patch Set 1 #

Patch Set 2 : diff -r ee3004c9d384 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ee3004c9d384 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 600c5389c9d3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/cmd/gc/go.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/racewalk.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/subr.c View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-06-12 11:29:56 UTC) #1
minux1
https://codereview.appspot.com/10227043/diff/4001/src/cmd/gc/subr.c File src/cmd/gc/subr.c (right): https://codereview.appspot.com/10227043/diff/4001/src/cmd/gc/subr.c#newcode2576 src/cmd/gc/subr.c:2576: if!flag_race && (isptr[rcvr->etype] && isptr[methodrcvr->etype] && method->embedded && !isifacemethod(method->type)) ...
12 years ago (2013-06-12 11:34:45 UTC) #2
dvyukov
On 2013/06/12 11:29:56, rsc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
12 years ago (2013-06-12 11:36:51 UTC) #3
DMorsing
We should probably add the racefuncexit stuff to the same codepath that generates deferreturn. That ...
12 years ago (2013-06-12 11:39:13 UTC) #4
rsc
On Wed, Jun 12, 2013 at 7:39 AM, <daniel.morsing@gmail.com> wrote: > We should probably add ...
12 years ago (2013-06-12 12:27:22 UTC) #5
rsc
On Wed, Jun 12, 2013 at 7:36 AM, <dvyukov@google.com> wrote: > Please add tests for ...
12 years ago (2013-06-12 12:34:34 UTC) #6
DMorsing
On 2013/06/12 12:27:22, rsc wrote: > On Wed, Jun 12, 2013 at 7:39 AM, <mailto:daniel.morsing@gmail.com> ...
12 years ago (2013-06-12 12:36:56 UTC) #7
dvyukov
On 2013/06/12 11:39:13, DMorsing wrote: > We should probably add the racefuncexit stuff to the ...
12 years ago (2013-06-13 09:00:23 UTC) #8
dvyukov
On 2013/06/12 12:34:34, rsc wrote: > On Wed, Jun 12, 2013 at 7:36 AM, <mailto:dvyukov@google.com> ...
12 years ago (2013-06-13 09:06:18 UTC) #9
rsc
Dmitriy, You still haven't LGTMed this, so the builders are still broken. I am submitting ...
12 years ago (2013-06-18 18:31:22 UTC) #10
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=6fdd68da7b70 *** cmd/gc: fix race detector on tail-call wrappers (By not using ...
12 years ago (2013-06-18 18:43:41 UTC) #11
dvyukov
12 years ago (2013-06-18 18:45:05 UTC) #12
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b