Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1340)

Issue 102270043: Resolve port conflicts for cf-nats

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by johnsca
Modified:
9 years, 11 months ago
Reviewers:
benjamin.saller, mp+222677
Visibility:
Public.

Description

Resolve port conflicts for cf-nats https://code.launchpad.net/~johnsca/charms/trusty/cf-nats/port-conflicts/+merge/222677 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Resolve port conflicts for cf-nats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -67 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/charmhelpers/contrib/cloudfoundry/contexts.py View 3 chunks +17 lines, -6 lines 0 comments Download
M hooks/charmhelpers/core/services.py View 4 chunks +81 lines, -55 lines 0 comments Download
M hooks/config.py View 1 chunk +4 lines, -4 lines 0 comments Download
M templates/nats.yml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
johnsca
Please take a look.
9 years, 11 months ago (2014-06-10 16:00:49 UTC) #1
benjamin.saller
LGTM, thanks for fixing the prefixes
9 years, 11 months ago (2014-06-11 22:35:53 UTC) #2
johnsca
9 years, 11 months ago (2014-06-12 18:34:49 UTC) #3
*** Submitted:

Resolve port conflicts for cf-nats

R=benjamin.saller
CC=
https://codereview.appspot.com/102270043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b