Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4670)

Issue 102210043: Now nameless items can also be downloaded (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by sksaurabhkathpalia
Modified:
9 years, 9 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

Now nameless items can also be downloaded

Patch Set 1 #

Patch Set 2 : Now defined separate function for getting download file name #

Total comments: 1

Patch Set 3 : Changed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M MoinMoin/items/content.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M MoinMoin/util/interwiki.py View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Thomas.J.Waldmann
looks ok. maybe needs a bit "optimizing for filename usage" though.
9 years, 10 months ago (2014-06-05 21:02:50 UTC) #1
sksaurabhkathpalia
On 2014/06/05 21:02:50, Thomas.J.Waldmann wrote: > looks ok. maybe needs a bit "optimizing for filename ...
9 years, 10 months ago (2014-06-06 11:15:25 UTC) #2
Thomas.J.Waldmann
On 2014/06/06 11:15:25, sksaurabhkathpalia wrote: > On 2014/06/05 21:02:50, Thomas.J.Waldmann wrote: > > looks ok. ...
9 years, 10 months ago (2014-06-14 17:40:40 UTC) #3
Thomas.J.Waldmann
> well, usually one should avoid spaces and other special characters in filenames > (I ...
9 years, 10 months ago (2014-06-14 17:41:28 UTC) #4
sksaurabhkathpalia
On 2014/06/14 17:40:40, Thomas.J.Waldmann wrote: > On 2014/06/06 11:15:25, sksaurabhkathpalia wrote: > > On 2014/06/05 ...
9 years, 10 months ago (2014-06-14 17:42:07 UTC) #5
sksaurabhkathpalia
On 2014/06/14 17:42:07, sksaurabhkathpalia wrote: > On 2014/06/14 17:40:40, Thomas.J.Waldmann wrote: > > On 2014/06/06 ...
9 years, 10 months ago (2014-06-14 18:01:16 UTC) #6
Thomas.J.Waldmann
9 years, 9 months ago (2014-07-05 15:56:39 UTC) #7
https://codereview.appspot.com/102210043/diff/20001/MoinMoin/util/interwiki.py
File MoinMoin/util/interwiki.py (right):

https://codereview.appspot.com/102210043/diff/20001/MoinMoin/util/interwiki.p...
MoinMoin/util/interwiki.py:112: returns the name of the file that is used for
downloading items
returns the filename that is used for downloading items
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b