Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 10215043: Update the validMachine regex for containers

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by thumper
Modified:
8 years, 5 months ago
Reviewers:
fwereade, mp+168837, wallyworld
Visibility:
Public.

Description

Update the validMachine regex for containers Yay regex. https://code.launchpad.net/~thumper/juju-core/fix-is-machine-id/+merge/168837 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update the validMachine regex for containers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/state.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state_test.go View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
thumper
Please take a look.
8 years, 5 months ago (2013-06-12 02:48:08 UTC) #1
wallyworld
LGTM with suggested extra test https://codereview.appspot.com/10215043/diff/1/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/10215043/diff/1/state/state_test.go#newcode930 state/state_test.go:930: } Please add one ...
8 years, 5 months ago (2013-06-12 03:02:10 UTC) #2
fwereade
LGTM https://codereview.appspot.com/10215043/diff/1/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/10215043/diff/1/state/state_test.go#newcode930 state/state_test.go:930: } On 2013/06/12 03:02:10, wallyworld wrote: > Please ...
8 years, 5 months ago (2013-06-12 09:12:07 UTC) #3
thumper
8 years, 5 months ago (2013-06-13 01:25:17 UTC) #4
*** Submitted:

Update the validMachine regex for containers

Yay regex.

R=wallyworld, fwereade
CC=
https://codereview.appspot.com/10215043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b