Issue 10215043: Update the validMachine regex for containers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10215043: Update the validMachine regex for containers

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by thumper

Modified:
10 years, 10 months ago

Reviewers:
fwereade, mp+168837, wallyworld

Visibility:
Public.

Description

Update the validMachine regex for containers Yay regex. https://code.launchpad.net/~thumper/juju-core/fix-is-machine-id/+merge/168837 (do not edit description out of merge proposal)

Patch Set 2 : Update the validMachine regex for containers #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/state_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wallyworld

LGTM with suggested extra test https://codereview.appspot.com/10215043/diff/1/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/10215043/diff/1/state/state_test.go#newcode930 state/state_test.go:930: } Please add one ...

10 years, 10 months ago (2013-06-12 03:02:10 UTC) #2

fwereade

LGTM https://codereview.appspot.com/10215043/diff/1/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/10215043/diff/1/state/state_test.go#newcode930 state/state_test.go:930: } On 2013/06/12 03:02:10, wallyworld wrote: > Please ...

10 years, 10 months ago (2013-06-12 09:12:07 UTC) #3

thumper

10 years, 10 months ago (2013-06-13 01:25:17 UTC) #4

*** Submitted:

Update the validMachine regex for containers

Yay regex.

R=wallyworld, fwereade
CC=
https://codereview.appspot.com/10215043

Expand All Messages | Collapse All Messages