code review 102040047: misc/makerelease: report uploads to the new downloads page

misc/makerelease: report uploads to the new downloads page

[adg, 2014-06-02 02:30:39]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-06-02 02:35:11]

LGT

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease.go
File misc/makerelease/makerelease.go (right):

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:52: defaultUploadURL =
"https://golang.org/dl/upload"
how does this work with https?  It doesn't work in Chrome: https://golang.org/
because of all the various App Engine / DNS whatever issues.

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:688: f := File{
this variable isn't really doing anything.  inline it into Marshal?

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:705: if resp.StatusCode != http.StatusOK {
defer resp.Body.Close()

[bradfitz, 2014-06-02 02:35:19]

LGTM even

[adg, 2014-06-02 02:42:53]

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease.go
File misc/makerelease/makerelease.go (right):

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:52: defaultUploadURL =
"https://golang.org/dl/upload"
On 2014/06/02 02:35:11, bradfitz wrote:
> how does this work with https?  It doesn't work in Chrome: https://golang.org/
> because of all the various App Engine / DNS whatever issues.

It doesn't work. s/https/http/

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:688: f := File{
On 2014/06/02 02:35:11, bradfitz wrote:
> this variable isn't really doing anything.  inline it into Marshal?

Done.

https://codereview.appspot.com/102040047/diff/1/misc/makerelease/makerelease....
misc/makerelease/makerelease.go:705: if resp.StatusCode != http.StatusOK {
On 2014/06/02 02:35:11, bradfitz wrote:
> defer resp.Body.Close()

Done.

[adg, 2014-06-02 02:46:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=f7d389e3cbac ***

misc/makerelease: report uploads to the new downloads page

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/102040047

[gobot, 2014-06-02 06:23:24]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/0342d994627ca4edfe430c9ee6debeeb7452a229