Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 102030047: code review 102030047: misc/goplay: remove program (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by adg
Modified:
11 years, 1 month ago
Reviewers:
gobot, minux, rsc
CC:
rsc, minux, golang-codereviews
Visibility:
Public.

Description

misc/goplay: remove program This program has barely been touched since it was first committed, and in its current state it opens a code execution vector similar to the one that was recently fixed in go.tools/playground/socket. Rather than try to make it secure, remove it.

Patch Set 1 #

Patch Set 2 : diff -r 1af13552a260 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -318 lines) Patch
R misc/goplay/Makefile View 1 chunk +0 lines, -6 lines 0 comments Download
R misc/goplay/README View 1 chunk +0 lines, -1 line 0 comments Download
R misc/goplay/doc.go View 1 chunk +0 lines, -23 lines 0 comments Download
R misc/goplay/goplay.go View 1 chunk +0 lines, -288 lines 0 comments Download

Messages

Total messages: 6
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2014-06-01 21:41:53 UTC) #1
minux
LGTM.
11 years, 1 month ago (2014-06-01 22:25:38 UTC) #2
rsc
Lgtm On Sunday, June 1, 2014, minux <minux@golang.org> wrote: > LGTM. >
11 years, 1 month ago (2014-06-01 22:27:00 UTC) #3
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=2daa4d89e0d9 *** misc/goplay: remove program This program has barely been touched since ...
11 years, 1 month ago (2014-06-01 22:34:38 UTC) #4
gobot
This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/79fb3d74f736f1edbb498b30b4b00ca365a081a8
11 years, 1 month ago (2014-06-01 22:37:10 UTC) #5
gobot
11 years, 1 month ago (2014-06-01 22:37:13 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64 builder.
See http://build.golang.org/log/ec7dcabfae0f8b3828a5588f854320e4321624a3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b