Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 101980050: Reorganize platform settings.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by bac
Modified:
9 years, 11 months ago
Reviewers:
mp+221745, redir
Visibility:
Public.

Description

Reorganize platform settings. The first cut of the platform work was a bit unclean with respect to the dividing lines between the quickstart app code and the parts that can be re-used as a library. This branch moves things around to re-attain that separation. https://code.launchpad.net/~bac/juju-quickstart/platform-settings-2/+merge/221745 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Reorganize platform settings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -176 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/app.py View 8 chunks +11 lines, -15 lines 0 comments Download
M quickstart/manage.py View 10 chunks +41 lines, -14 lines 0 comments Download
M quickstart/platform_support.py View 3 chunks +31 lines, -38 lines 0 comments Download
M quickstart/settings.py View 2 chunks +16 lines, -2 lines 0 comments Download
M quickstart/tests/test_app.py View 19 chunks +46 lines, -51 lines 0 comments Download
M quickstart/tests/test_manage.py View 8 chunks +57 lines, -16 lines 0 comments Download
M quickstart/tests/test_platform_support.py View 2 chunks +23 lines, -35 lines 0 comments Download
M quickstart/tests/test_utils.py View 1 chunk +3 lines, -3 lines 0 comments Download
M quickstart/utils.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
9 years, 11 months ago (2014-06-02 14:34:47 UTC) #1
bac
QA instructions: The changes include the things you requested plus a later change to set ...
9 years, 11 months ago (2014-06-02 15:39:35 UTC) #2
redir
On 2014/06/02 15:39:35, bac wrote: > QA instructions: > > The changes include the things ...
9 years, 11 months ago (2014-06-02 16:09:32 UTC) #3
bac
9 years, 11 months ago (2014-06-02 19:56:24 UTC) #4
*** Submitted:

Reorganize platform settings.

The first cut of the platform work was a bit unclean with respect to the
dividing lines between the quickstart app code and the parts that can be
re-used as a library.  This branch moves things around to re-attain that
separation.

R=redir
CC=
https://codereview.appspot.com/101980050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b