Alert button bootstrap overwrite file

Alert button bootstrap overwrite file

This branch takes the first step towards removing bootstrap
from the GUI by creating a bootstrap overwrite file. As of now
this overwrite file simply duplicates the styles from bootstrap
for the alert overwriting the bootstrap ones so it will be easier
to restyle.

https://code.launchpad.net/~hatch/juju-gui/alert-dropdown/+merge/168805

(do not edit description out of merge proposal)

[jeff.pihach, 2013-06-11 20:34:12]

Please take a look.

[gary.poster, 2013-06-11 20:37:31]

I have no idea if this helps, but we can give it a try. :-)

Thanks

Gary

https://codereview.appspot.com/10197043/diff/1/app/config-debug.js
File app/config-debug.js (right):

https://codereview.appspot.com/10197043/diff/1/app/config-debug.js#newcode45
app/config-debug.js:45: sandbox: false,
we agreed sandbox should be true for debug I think

[gary.poster, 2013-06-11 20:37:40]

Oh and LGTM :-P

[jeff.pihach, 2013-06-11 20:43:50]

Thanks for the review

https://codereview.appspot.com/10197043/diff/1/app/config-debug.js
File app/config-debug.js (right):

https://codereview.appspot.com/10197043/diff/1/app/config-debug.js#newcode45
app/config-debug.js:45: sandbox: false,
Oops sorry, changed!

[matthew.scott, 2013-06-11 20:45:55]

LGTM, thanks for starting this!

https://codereview.appspot.com/10197043/diff/1/app/assets/stylesheets/juju-bo...
File app/assets/stylesheets/juju-bootstrap.css (right):

https://codereview.appspot.com/10197043/diff/1/app/assets/stylesheets/juju-bo...
app/assets/stylesheets/juju-bootstrap.css:3: relies on it's styles, when you
find a bootstrap specific class style copy the
No apostrophe on "it's".

[jeff.pihach, 2013-06-11 20:46:46]

Thanks for the review, fixed!

[jeff.pihach, 2013-06-11 20:59:19]

*** Submitted:

Alert button bootstrap overwrite file

This branch takes the first step towards removing bootstrap
from the GUI by creating a bootstrap overwrite file. As of now
this overwrite file simply duplicates the styles from bootstrap
for the alert overwriting the bootstrap ones so it will be easier
to restyle.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/10197043

[jeff.pihach, 2013-06-11 21:21:54]

Please take a look.

[gary.poster, 2013-06-11 21:26:59]

On 2013/06/11 21:21:54, jeff.pihach wrote:
> Please take a look.

QA is good in prod

Thank you

[jeff.pihach, 2013-06-11 21:34:12]

*** Submitted:

Alert button bootstrap overwrite file

This branch takes the first step towards removing bootstrap
from the GUI by creating a bootstrap overwrite file. As of now
this overwrite file simply duplicates the styles from bootstrap
for the alert overwriting the bootstrap ones so it will be easier
to restyle.

R=gary.poster
CC=
https://codereview.appspot.com/10197043

[jeff.pihach, 2013-06-11 21:47:38]

*** Submitted:

Alert button bootstrap overwrite file

This branch takes the first step towards removing bootstrap
from the GUI by creating a bootstrap overwrite file. As of now
this overwrite file simply duplicates the styles from bootstrap
for the alert overwriting the bootstrap ones so it will be easier
to restyle.

R=
CC=
https://codereview.appspot.com/10197043