Issue 10193043: Fixes #1189929 fix routing to not double QS.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10193043: Fixes #1189929 fix routing to not double QS.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
mp+168780, j.c.sackett, jeff.pihach

Visibility:
Public.

Description

Fixes #1189929 fix routing to not double QS. - The router combine method already handles adding the query string to the url, but the _navigate was also adding it. - We remove the _navigate code since it's always calling combine and will have a query string. https://code.launchpad.net/~rharding/juju-gui/category-urls-1189929/+merge/168780 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes #1189929 fix routing to not double QS. #

Patch Set 3 : Fixes #1189929 fix routing to not double QS. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/assets/javascripts/ns-routing-app-extension.js	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rharding

10 years, 10 months ago (2013-06-11 18:06:45 UTC) #5

*** Submitted:

Fixes #1189929 fix routing to not double QS.

- The router combine method already handles adding the query string to the
url, but the _navigate was also adding it.
- We remove the _navigate code since it's always calling combine and will have
a query string.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/10193043

Expand All Messages | Collapse All Messages